Skip to content

feat(metadata): support Space URL appData - #124

Merged
neekolas merged 1 commit into
mainfrom
feat/appdata-space-url
Aug 7, 2026
Merged

feat(metadata): support Space URL appData#124
neekolas merged 1 commit into
mainfrom
feat/appdata-space-url

Conversation

@neekolas

@neekolas neekolas commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add optional ConversationCustomMetadata.spaceUrl at protobuf field 9.
  • Read and write the field through the existing appData codec with last-write-wins behavior.
  • Verify the wire field, an iOS-generated vector, and safe handling of the deprecated unknown connections field.
  • Include a patch Changeset for the downstream Herald release.

This is the codec contract Herald Lite and assistant creation will use in follow-up PRs. It does not change appData compression behavior.

Validation

  • pnpm exec vitest run test/utils/metadata.test.ts — 45 passed
  • pnpm typecheck
  • pnpm build
  • git diff --check

Comment thread src/utils/metadata.ts Outdated
@macroscopeapp

macroscopeapp Bot commented Aug 7, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved 4835ad7

This PR adds a new optional spaceUrl field to the conversation metadata protobuf schema. The change is purely additive - existing serialization/deserialization behavior is unchanged, and optional protobuf fields are backward compatible by design. Comprehensive tests verify correct encoding and round-trip behavior.

You can customize Macroscope's approvability policy. Learn more.

@neekolas
neekolas enabled auto-merge (squash) August 7, 2026 05:18
@neekolas
neekolas disabled auto-merge August 7, 2026 05:18
@neekolas
neekolas force-pushed the feat/appdata-space-url branch from de8283c to 4835ad7 Compare August 7, 2026 05:47
@neekolas
neekolas merged commit 025c171 into main Aug 7, 2026
5 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant