refactor(metadata): move spaceUrl to protobuf field 10 - #128
Conversation
Co-Authored-By: Nick Molnar <iam+git@nicholasmolnar.com>
Original prompt from Nick
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
ApprovabilityVerdict: Needs human review This PR changes a protobuf field number from 9 to 10, which is a wire-format change that could affect existing serialized data. The changeset mentions deconflicting with field 9 but doesn't clarify what the conflict is - a human reviewer should verify the rationale and any backward compatibility implications. You can customize Macroscope's approvability policy. Learn more. |
Summary
ConversationCustomMetadata.spaceUrl(added in #124) claimed protobuf field 9, which conflicts with an incoming feature. SincespaceUrlisn't deployed or used anywhere yet, this moves it to field 10 — a wire-format change with no migration path needed.Test wire vectors updated accordingly:
encodeStringField(9, ...)→encodeStringField(10, ...), and the iOS-generated base64url vector regenerated with tag0x52instead of0x4a.Validation
vitest run test/utils/metadata.test.ts— 45 passedpnpm typecheckLink to Devin session: https://app.devin.ai/sessions/e93766cf947b4a158e8d7b2bb601caa5
Requested by: @neekolas
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Note
Move
ConversationCustomMetadata.spaceUrlto protobuf field 10Reassigns
spaceUrlfrom field 9 to field 10 in the protobuf schema defined in metadata.ts to avoid a conflict with field 9. Tests are updated to reflect the new field number and wire encoding. Risk: any previously encodedspaceUrlvalues at field 9 will not decode correctly after this change.Macroscope summarized ac445d1.