Skip to content

refactor(metadata): move spaceUrl to protobuf field 10 - #128

Merged
neekolas merged 1 commit into
mainfrom
devin/1786296396-space-url-field-10
Aug 9, 2026
Merged

refactor(metadata): move spaceUrl to protobuf field 10#128
neekolas merged 1 commit into
mainfrom
devin/1786296396-space-url-field-10

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

ConversationCustomMetadata.spaceUrl (added in #124) claimed protobuf field 9, which conflicts with an incoming feature. Since spaceUrl isn't deployed or used anywhere yet, this moves it to field 10 — a wire-format change with no migration path needed.

-  .add(new protobuf.Field("spaceUrl", 9, "string", "optional"));
+  .add(new protobuf.Field("spaceUrl", 10, "string", "optional"));

Test wire vectors updated accordingly: encodeStringField(9, ...)encodeStringField(10, ...), and the iOS-generated base64url vector regenerated with tag 0x52 instead of 0x4a.

Validation

  • vitest run test/utils/metadata.test.ts — 45 passed
  • pnpm typecheck

Link to Devin session: https://app.devin.ai/sessions/e93766cf947b4a158e8d7b2bb601caa5
Requested by: @neekolas


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Note

Move ConversationCustomMetadata.spaceUrl to protobuf field 10

Reassigns spaceUrl from field 9 to field 10 in the protobuf schema defined in metadata.ts to avoid a conflict with field 9. Tests are updated to reflect the new field number and wire encoding. Risk: any previously encoded spaceUrl values at field 9 will not decode correctly after this change.

Macroscope summarized ac445d1.

Co-Authored-By: Nick Molnar <iam+git@nicholasmolnar.com>
@neekolas neekolas self-assigned this Aug 9, 2026
@neekolas
neekolas self-requested a review August 9, 2026 17:26
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author
Original prompt from Nick

In this PR we added the spaceURL field at position 9. There is an incoming conflict for another feature using position 9. Let's create a new PR that moves spaceURL to field 10 to deconflict. It has not yet been deployed or used anywhere.

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@neekolas
neekolas merged commit f5138db into main Aug 9, 2026
5 checks passed
@macroscopeapp

macroscopeapp Bot commented Aug 9, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

This PR changes a protobuf field number from 9 to 10, which is a wire-format change that could affect existing serialized data. The changeset mentions deconflicting with field 9 but doesn't clarify what the conflict is - a human reviewer should verify the rationale and any backward compatibility implications.

You can customize Macroscope's approvability policy. Learn more.

@github-actions github-actions Bot mentioned this pull request Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant