Add SVG snapshot for acute line joins - #230
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
force-pushed
the
agent/add-line-join-repro
branch
from
August 12, 2026 18:33
048c3cd to
bcb1ff4
Compare
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toMatchSvgSnapshotregression case for a thick, acute polylineWhy
The existing line snapshots use straight two-point segments, so they cannot reveal a line-join regression. This fixture creates an intentionally sharp corner with a thick stroke, making the current pointed miter easy to see and giving the round-line-join fix in the stacked PR a meaningful SVG snapshot diff.
This PR contains only the reproduction and baseline snapshot. PR #229 will be retargeted on top of this branch with the renderer change and updated rounded snapshot.
Validation
bun test(69 passing)bun run format:checkgit diff --check