Render lines with round joins - #229
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
force-pushed
the
agent/round-line-joins
branch
from
August 12, 2026 18:19
84603ca to
9416fa8
Compare
seveibar
force-pushed
the
agent/add-line-join-repro
branch
from
August 12, 2026 18:33
048c3cd to
bcb1ff4
Compare
seveibar
force-pushed
the
agent/round-line-joins
branch
from
August 12, 2026 18:33
9416fa8 to
1c22e51
Compare
seveibar
marked this pull request as ready for review
August 12, 2026 18:39
seveibar
added a commit
that referenced
this pull request
Aug 12, 2026
* Add line join SVG repro * Render lines with round joins (#229)
This was referenced Aug 12, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stroke-linejoin="round"for lines in generated SVGsStack
toMatchSvgSnapshotfixture and captures the current pointed miterWhy
Exported SVG lines fell back to SVG's miter join default, even though the interactive renderer already used rounded joins. Canvas rendering likewise only configured rounded end caps. This makes line appearance consistent across renderers and avoids sharp spikes at polyline corners.
The stacked snapshot uses a thick, acute V-shaped polyline. Before accepting the new snapshot, the matcher produced a visual diff highlighting the old triangular miter beyond the new rounded bend.
Validation
bun test(69 passing)bun run format:checkbun run buildgit diff --check