Skip to content

어드민 dev 계정 이메일 판별 규칙 수정 - #616

Merged
whqtker merged 1 commit into
mainfrom
fix/admin-dev-email-pattern
Aug 1, 2026
Merged

어드민 dev 계정 이메일 판별 규칙 수정#616
whqtker merged 1 commit into
mainfrom
fix/admin-dev-email-pattern

Conversation

@whqtker

@whqtker whqtker commented Aug 1, 2026

Copy link
Copy Markdown
Member

요약

#615에서 어드민 로그인 계정에 따라 dev/prod API를 런타임 전환하는 기능을 추가하면서, dev 계정 판별 규칙을 @dev.solid-connection.com 서브도메인으로 가정하고 구현했습니다. 실제 dev 관리자 계정은 dev@solid-connection.com(로컬파트가 정확히 "dev", 도메인은 prod와 동일)이라 패턴이 맞지 않아 dev 계정으로 로그인하면 prod API(api.solid-connection.com)로 요청이 가서 401이 발생했습니다.

변경

  • resolveEnvironmentFromEmail을 로컬파트 정확히 dev 일치로 수정
  • environment.test.ts를 실제 이메일 기준으로 갱신
  • #613에서 재작성된 auth.test.ts의 mock 예시(@dev.solid-connection.com)도 실제 이메일로 갱신 (mock이라 테스트 통과에는 영향 없었지만, 잘못된 패턴을 계속 문서화하고 있어 함께 수정)

Test plan

  • pnpm --filter admin typecheck
  • pnpm --filter admin lint:check
  • pnpm --filter admin test (33 tests passed)
  • pnpm --filter admin build
  • 실제 dev 계정(dev@solid-connection.com)으로 로그인해 stage API 호출 확인

#615에서 dev/prod 판별 규칙을 서브도메인(@dev.solid-connection.com)으로
가정하고 구현했으나, 실제 dev 관리자 계정은 dev@solid-connection.com
(로컬파트가 정확히 "dev")이라 패턴이 안 맞아 dev 계정 로그인이 prod
API로 전송되어 401이 발생했다. 로컬파트 정확히 일치로 판별 규칙을
수정하고, #613에서 재작성된 auth.test.ts의 mock 예시도 실제 이메일에
맞춰 갱신했다.
@whqtker
whqtker requested review from manNomi and wibaek as code owners August 1, 2026 13:09
@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview Aug 1, 2026 1:11pm
solid-connect-web-admin Ready Ready Preview Aug 1, 2026 1:11pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connection-web Skipped Skipped Aug 1, 2026 1:11pm

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@whqtker, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 980d316c-d08f-4280-b142-58ddd46f7b0d

📥 Commits

Reviewing files that changed from the base of the PR and between a283ad3 and 96e3af9.

📒 Files selected for processing (3)
  • apps/admin/src/lib/api/auth.test.ts
  • apps/admin/src/lib/auth/environment.test.ts
  • apps/admin/src/lib/auth/environment.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the admin label Aug 1, 2026
@whqtker whqtker changed the title 어드민 dev 계정 이메일 판별 규칙 수정 (dev@solid-connection.com) 어드민 dev 계정 이메일 판별 규칙 수정 Aug 1, 2026
@whqtker whqtker self-assigned this Aug 1, 2026
@whqtker
whqtker merged commit 3c663ae into main Aug 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant