๐ฅ ๋ฆด๋ฆฌ์ฆ ์น๊ฒฉ ์ํฌํ๋ก์์ admin ํ๊น ์ ๊ฑฐ (admin: main ๋ณํฉ = ํ๋ก๋์ ๋ฐฐํฌ) - #618
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ๐ฅ Pre-merge checks | โ 5โ Passed checks (5 passed)
โจ Finishing Touches๐งช Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
๐ค Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/git-cicd.md`:
- Around line 42-44: Update the versioning section in docs/git-cicd.md to
separate headver.jsonโs app-specific head values from HEADVer tag creation
performed by .github/workflows/headver-tagging.yml. Clarify that post-deployment
manual updates and Promote Main to Release Branches/release-* branch promotion
are not part of the current process, rather than documenting them as required
operational steps.
In `@docs/university-multizone-deployment.md`:
- Around line 69-75: The deployment documentation must explicitly require
updating Vercel settings before relying on main-branch production deployments.
In docs/university-multizone-deployment.md lines 69-75, add steps before the
production-branch guidance to set each Vercel Projectโs Settings > Git >
Production Branch to main. In docs/git-cicd.md lines 42-44, state that this
Vercel configuration must be completed before describing main pushes as
triggering production deployments.
- Around line 69-75: ๋ฌธ์์ Vercel production ๋ฐฐํฌ ์ค๋ช
์ ๊ฐ ํ๋ก์ ํธ์ ์ค์ ์ ์ฐจ๋ฅผ ์ถ๊ฐํ์ธ์. Main
Web, Admin, University Web Project์์ ๊ฐ๊ฐ Settings > Git์ Production Branch๋ฅผ
main์ผ๋ก ์ง์ ํ๊ณ , ์ค์ ์ ํ ํ main push๊ฐ production ๋ฐฐํฌ๋ฅผ ํธ๋ฆฌ๊ฑฐํ๋์ง ํ์ธํ๋ ๋จ๊ณ๊น์ง ๋ช
์ํ์ธ์.
๐ช Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
โน๏ธ Review info
โ๏ธ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b52f431e-83cc-49eb-ac75-bd764c1b61d0
๐ Files selected for processing (3)
.github/workflows/release.ymldocs/git-cicd.mddocs/university-multizone-deployment.md
๐ค Files with no reviewable changes (1)
- .github/workflows/release.yml
| main ๋ธ๋์น์ push๊ฐ ๋๋ฉด ์๋์ผ๋ก CI๊ฐ ์งํ๋๊ณ , ๊ฐ Vercel Project์ production ํ๊ฒฝ์ ๋ฐฐํฌ๋ฉ๋๋ค. ๊ฐ Vercel Project์ production branch๋ `main`์ ๋๋ค. | ||
|
|
||
| Github Actions์ `Promote Main to Release Branches`๋ฅผ ๊ฐ๋์ํค๋ฉด ์ ํํ release branch๊ฐ main์ผ๋ก ๊ฐฑ์ ๋๊ณ , ๊ฐ Vercel Project์ production ํ๊ฒฝ์ ๋ฐฐํฌ๋ฉ๋๋ค. | ||
|
|
||
| - `release-web`: web production ๋ฐฐํฌ | ||
| - `release-admin`: admin production ๋ฐฐํฌ | ||
| - `release-university`: university-web production ๋ฐฐํฌ | ||
|
|
||
| ๋ฆด๋ฆฌ์ฆ workflow์ target์ ๋ค์๊ณผ ๊ฐ์ด ์ฌ์ฉํฉ๋๋ค. | ||
|
|
||
| - `all`: web, admin, university-web ์ ์ฒด ๋ฆด๋ฆฌ์ฆ | ||
| - `web`: web๋ง ๋ฆด๋ฆฌ์ฆ | ||
| - `admin`: admin๋ง ๋ฆด๋ฆฌ์ฆ | ||
| - `university`: university-web๋ง ๋ฆด๋ฆฌ์ฆ | ||
|
|
||
| ๊ธฐ๋ณธ๊ฐ์ `all`์ ๋๋ค. ํน์ project๋ง production ๋ฆด๋ฆฌ์ฆํ๋ ค๋ฉด `web`, `admin`, `university`๋ฅผ ์ ํํฉ๋๋ค. | ||
| ๊ณผ๊ฑฐ์๋ main ๋ณํฉ ํ GitHub Actions์ `Promote Main to Release Branches`๋ก release branch(`release-web`/`release-admin`/`release-university`)๋ฅผ ๊ฐฑ์ ํด์ผ production์ด ๋ฐฐํฌ๋์์ผ๋, ํด๋น workflow์ release branch ์น๊ฒฉ ๋จ๊ณ๋ ์ ๊ฑฐ๋์์ต๋๋ค. main ๋ณํฉ์ด ๊ณง production ๋ฐฐํฌ์ ๋๋ค. |
There was a problem hiding this comment.
๐๏ธ Data Integrity & Integration | ๐ Major | ๐๏ธ Heavy lift
๐งฉ Analysis chain
๐ Script executed:
#!/bin/bash
set -euo pipefail
echo "== files =="
git ls-files | sed -n '1,120p'
echo "== docs/git-cicd.md lines 1-90 =="
cat -n docs/git-cicd.md | sed -n '1,90p'
echo "== workflow/headver/release references =="
rg -n "HeadVer|headver|release branch|release-web|release-admin|release-university|GitHub Release|Promote Main|create.*release|Create Release|gh release|release" -S . --glob '!node_modules' --glob '!dist' --glob '!build' | sed -n '1,240p'Repository: solid-connection/solid-connect-web
Length of output: 8249
๐ Script executed:
#!/bin/bash
set -euo pipefail
echo "== workflow files =="
cat -n .github/workflows/ci.yml
echo "---"
cat -n .github/workflows/headver-tagging.yml
echo "== scripts =="
cat -n .github/scripts/create-headver-tag.sh
echo "== headver.json tracked/config =="
for f in $(git ls-files | grep -E '(^|/)headver\.json$|^pnpm-workspace\.yaml$|^package\.json$'); do
echo "--- $f"
sed -n '1,120p' "$f"
done
echo "== docs onboarding lines 45-58 =="
cat -n docs/onboarding.md | sed -n '45,58p'Repository: solid-connection/solid-connect-web
Length of output: 14206
1. HeadVer ํ๊น ๊ณผ release branch ๊ณผ์ ์ ๋ฌธ์์์ ๋ถ๋ฆฌํ์ธ์.
docs/git-cicd.md์ ๋ฒ์ ๋ ์น์
์ด ํ์ฌ CI ์ํ์ ๋ง์ง ์์ต๋๋ค. headver.json์ ํ์ฌ ์ฑ๋ณ head ๊ฐ๋ง ์ ์ฅ๋๊ณ , HEADVer ํ๊น
์ .github/workflows/headver-tagging.yml์์ ๋ณ๋ ํธ์ถํด ์์ฑํฉ๋๋ค. ๋ฐฐํฌ ์ดํ ์๋ ์
๋ฐ์ดํธ๋ Promote Main to Release Branches/release-* branch ๊ฐฑ์ ๊ณผ์ ์ ์ด์ ์ ์ฐจ์ ์ถ๊ฐํ๊ฑฐ๋, ํ์ฌ ์ ์ฐจ๊ฐ ์๋์ ๋ถ๋ช
ํ ์ ์ด์ฃผ์ธ์.
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/git-cicd.md` around lines 42 - 44, Update the versioning section in
docs/git-cicd.md to separate headver.jsonโs app-specific head values from
HEADVer tag creation performed by .github/workflows/headver-tagging.yml. Clarify
that post-deployment manual updates and Promote Main to Release
Branches/release-* branch promotion are not part of the current process, rather
than documenting them as required operational steps.
| production ๋ฐฐํฌ๋ main ๋ธ๋์น ๋ณํฉ์ผ๋ก ํธ๋ฆฌ๊ฑฐ๋๋ค. ๊ฐ Vercel Project์ production branch๋ `main`์ด๋ฉฐ, main์ push๋๋ฉด ํด๋น project์ production ํ๊ฒฝ์ ๋ฐฐํฌ๋๋ค. | ||
|
|
||
| - Main Web Project production branch: `release-web` | ||
| - Admin Project production branch: `release-admin` | ||
| - University Web Project production branch: `release-university` | ||
| - Main Web Project production branch: `main` | ||
| - Admin Project production branch: `main` | ||
| - University Web Project production branch: `main` | ||
|
|
||
| workflow target์ ๋ค์๊ณผ ๊ฐ์ด ์ฌ์ฉํ๋ค. | ||
|
|
||
| - `all`: `release-web`, `release-admin`, `release-university`๋ฅผ ๋ชจ๋ main์ผ๋ก ๊ฐฑ์ | ||
| - `web`: `release-web`๋ง main์ผ๋ก ๊ฐฑ์ | ||
| - `admin`: `release-admin`๋ง main์ผ๋ก ๊ฐฑ์ | ||
| - `university`: `release-university`๋ง main์ผ๋ก ๊ฐฑ์ | ||
|
|
||
| workflow ๊ธฐ๋ณธ๊ฐ์ `all`์ด๋ค. ๊ฐ๋ณ production ๋ฐฐํฌ๊ฐ ํ์ํ๋ฉด `web`, `admin`, `university`๋ฅผ ์ ํํ๋ค. | ||
| (๊ณผ๊ฑฐ์๋ `Promote Main to Release Branches` workflow๋ก `release-web`/`release-admin`/`release-university` ๋ธ๋์น๋ฅผ ๊ฐฑ์ ํด production ๋ฐฐํฌ๋ฅผ ํธ๋ฆฌ๊ฑฐํ์ผ๋, ํด๋น workflow์ release branch ์น๊ฒฉ ๋จ๊ณ๋ ์ ๊ฑฐ๋์๋ค.) |
There was a problem hiding this comment.
๐ฉบ Stability & Availability | ๐ Major | ๐๏ธ Heavy lift
๐งฉ Analysis chain
๐ Script executed:
#!/bin/bash
set -euo pipefail
echo "== files =="
git ls-files | rg '(^docs/.*multizone|^docs/git-cicd\.md$|^vercel\.json$|github\.workflows/.+\.(ya?ml))' || true
echo
echo "== docs snippets =="
sed -n '55,85p' docs/university-multizone-deployment.md 2>/dev/null || true
echo "---"
sed -n '32,52p' docs/git-cicd.md 2>/dev/null || true
echo
echo "== workflow references =="
rg -n "Promote Main to Release Branches|release-(web|admin|university)|production branch|productionBranch|Deployment|vercel|project" .github docs vercel.json 2>/dev/null || true
echo
echo "== vercel config =="
cat -n vercel.json 2>/dev/null || trueRepository: solid-connection/solid-connect-web
Length of output: 7254
1. Vercel Production Branch ์ ํ์ ๋ฐฐํฌ ์ ์ ์กฐ๊ฑด์ผ๋ก ๋ช ์ํ์ธ์.
Vercel productionBranch๋ ์ ์ฅ์ ํ์ผ์ด ์๋๋ผ ๊ฐ Vercel Project ์ค์ ์ผ๋ก ์ ํด์ง๋๋ค.
1) university-multizone-deployment.md์ production branch ์๋ด ์๋จ์์ ๊ฐ Project์ Vercel Settings > Git > Production Branch๋ฅผ `main`์ผ๋ก ๋ณ๊ฒฝํ๋ ์์๋ฅผ ์ถ๊ฐํ์ธ์.
2) git-cicd.md์ `main` push โ production ๋ฐฐํฌ ์ค๋ช
์์ Vercel ์ค์ ์๋ฃ ์กฐ๊ฑด์ ๋ช
์ํ์ธ์.
๐ Affects 2 files
docs/university-multizone-deployment.md#L69-L75(this comment)docs/git-cicd.md#L42-L44
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/university-multizone-deployment.md` around lines 69 - 75, The deployment
documentation must explicitly require updating Vercel settings before relying on
main-branch production deployments. In docs/university-multizone-deployment.md
lines 69-75, add steps before the production-branch guidance to set each Vercel
Projectโs Settings > Git > Production Branch to main. In docs/git-cicd.md lines
42-44, state that this Vercel configuration must be completed before describing
main pushes as triggering production deployments.
๐ฉบ Stability & Availability | ๐ Major | ๐๏ธ Heavy lift
๐งฉ Analysis chain
๐ Script executed:
#!/bin/bash
set -euo pipefail
echo "== files =="
git ls-files | sed -n '1,120p'
echo
echo "== target doc excerpt =="
if [ -f docs/university-multizome-deployment.md ]; then
sed -n '1,120p' docs/university-multizone-deployment.md
else
fd -a 'university-multizone-deployment\.md' . | while read -r f; do
echo "-- $f"
sed -n '1,120p' "$f"
done
fi
echo
echo "== search vercel deployment docs/workflows =="
rg -n "Vercel|production branch|Production Branch|Vercl|release-web|release-admin|release-university|Promote Main to Release Branches|็ไบง|๋ฐฐํฌ" -S . --glob '!node_modules' --glob '!dist' --glob '!build' | sed -n '1,220p'Repository: solid-connection/solid-connect-web
Length of output: 13736
๐ Script executed:
#!/bin/bash
set -euo pipefail
echo "== workflows =="
for f in .github/workflows/*.yml .github/workflows/*.yaml; do
[ -f "$f" ] || continue
echo "-- $f"
wc -l "$f"
sed -n '1,220p' "$f" | sed -n '1,220p'
done
echo
echo "== git-cicd relevant =="
sed -n '1,90p' docs/git-cicd.md
echo
echo "== search release workflow files in history briefly =="
git ls-files .github/workflows | xargs -r -I{} sh -c 'echo "== {} =="; sed -n "1,220p" "{}" | grep -nE "release|release-(web|admin|university)|Promote|deploy|push_to_release|production branch|production branch" || true'Repository: solid-connection/solid-connect-web
Length of output: 21343
1. Vercel Production Branch ์ค์ ์ ์ฐจ๋ฅผ ๋ฌธ์์ ์ถ๊ฐํ์ธ์.
๋ฌธ์๋ production branch๊ฐ ์ด๋ฏธ main์ด๋ผ๊ณ ์ค๋ช
ํ์ง๋ง, ๋ฐฐํฌ ์ํฌํ๋ก๋ release ๋ธ๋์น ๊ฐฑ์ ์ ์ ๊ฑฐํ์ ๋ฟ Vercel ์ค์ ์ ๋์ฒดํ์ง ์์ต๋๋ค.
- ๊ฐ ํ๋ก์ ํธ์์ `Settings > Git`์ Production Branch๋ฅผ `main`์ผ๋ก ์ค์ ํฉ๋๋ค.
- ์ ํ ํ `main` push๋ก ์์ฐ ํ๊ฒฝ์ ๋ฐฐํฌ๋๋์ง ๊ฐ ํ๋ก์ ํธ์์ ํ์ธํฉ๋๋ค.
๐ค Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/university-multizone-deployment.md` around lines 69 - 75, ๋ฌธ์์ Vercel
production ๋ฐฐํฌ ์ค๋ช
์ ๊ฐ ํ๋ก์ ํธ์ ์ค์ ์ ์ฐจ๋ฅผ ์ถ๊ฐํ์ธ์. Main Web, Admin, University Web
Project์์ ๊ฐ๊ฐ Settings > Git์ Production Branch๋ฅผ main์ผ๋ก ์ง์ ํ๊ณ , ์ค์ ์ ํ ํ main push๊ฐ
production ๋ฐฐํฌ๋ฅผ ํธ๋ฆฌ๊ฑฐํ๋์ง ํ์ธํ๋ ๋จ๊ณ๊น์ง ๋ช
์ํ์ธ์.
65ffeff to
474a5ae
Compare
์์ฝ
Promote Main to Release Branchesworkflow์์ admin ํ๊น๋ง ์ ๊ฑฐํฉ๋๋ค. web/university์ release branch ์น๊ฒฉ ๋ฐฐํฌ๋ ๊ทธ๋๋ก ์ ์ง๋ฉ๋๋ค.release-admin์น๊ฒฉ ๋จ๊ณ๊ฐ ์ฌ๋ผ์ง๋๋ค.docs/git-cicd.md,docs/university-multizone-deployment.md์ admin ๋ฐฐํฌ ์ค๋ช ์ ๊ฐฑ์ ํ์ต๋๋ค.๋ฐฐ๊ฒฝ
์ด๋๋ฏผ์ API ํ๊ฒฝ(stage/prod) ๋ฐํ์ ์ ํ์ด ๋์ ๋๋ฉด์(#615, #616, ํ์์ผ๋ก ํ๋กํ ์ค์์ฒ ์์ ) ์ด๋๋ฏผ์ stage + production ์ด์ค์ผ๋ก ๊ด๋ฆฌํ ํ์๊ฐ ์์ด์ก์ต๋๋ค. admin ๋ฐฐํฌ๋ฅผ main ํ๋๋ก ํตํฉํ๊ณ , stage/prod API ์ ํ์ ์ฑ ์์์ ์ฒ๋ฆฌํฉ๋๋ค.
ํ์ํ ํ์ ์์ (Vercel, ์ ์ฅ์ ์ค์ )
release-adminโmain์ผ๋ก ๋ณ๊ฒฝ (@hanmw110 ์งํ ์์ )release-admin๋ธ๋์น ์ ๋ฆฌ(์ ํ)ํน์ด ์ฌํญ
release-admin์ด ๋ ์ด์ ๊ฐฑ์ ๋์ง ์์ผ๋ฏ๋ก admin ํ๋ก๋์ ๋ฐฐํฌ ์๋จ์ด ์ผ์์ ์ผ๋ก ์์ต๋๋ค. ๋จธ์ง ์งํ Vercel ์ค์ ๋ณ๊ฒฝ์ ๊ถ์ฅํฉ๋๋ค..github/scripts/create-headver-tag.sh์ admin ๋ถ๊ธฐ๋ ๋ค๋ฅธ ๊ณณ์์ ์ฌ์ฌ์ฉ๋ ์ ์์ด ๋จ๊ฒจ๋์์ต๋๋ค.๐ค Generated with Claude Code