Skip to content

OCPBUGS-97948: Fix ClusterExtension Progressing condition stuck at True after successful install #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vdurgam10 wants to merge 1 commit into
base: release-4.22
Choose a base branch
from
+2 −1
Open

OCPBUGS-97948: Fix ClusterExtension Progressing condition stuck at True after successful install #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/operator-controller/controllers/common_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,14 @@ func setInstallStatus(ext *ocv1.ClusterExtension, installStatus *ocv1.ClusterExt
func setStatusProgressing(ext *ocv1.ClusterExtension, err error) {
progressingCond := metav1.Condition{
Type: ocv1.TypeProgressing,
Status: metav1.ConditionTrue,
Status: metav1.ConditionFalse,
Reason: ocv1.ReasonSucceeded,
Message: "Desired state reached",
ObservedGeneration: ext.GetGeneration(),
}

if err != nil {
progressingCond.Status = metav1.ConditionTrue
progressingCond.Reason = ocv1.ReasonRetrying
// Unwrap TerminalError to avoid "terminal error:" prefix in message
progressingCond.Message = errorutil.SanitizeNetworkError(errorutil.UnwrapTerminal(err))
Expand Down