OCPBUGS-97948: Fix ClusterExtension Progressing condition stuck at True after successful install

[vdurgam10]

Bug: https://redhat.atlassian.net/browse/OCPBUGS-97948

Summary

• The setStatusProgressing function in common_controller.go defaults the Progressing condition to Status=True with Reason=Succeeded when no error occurs. Per standard Kubernetes condition conventions, Progressing=True means work is still in progress. When the desired state has been reached (no error), Progressing should be False.
• This causes oc get clusterextension to permanently show PROGRESSING=True even when the operator is fully installed and running correctly.
• Fix: default to ConditionFalse (done progressing) and only set ConditionTrue when a non-terminal error triggers a retry.
• Affects: 4.18, 4.19, 4.20, 4.21, 4.22, main (all versions since ClusterExtension v1 API was introduced in 4.18)

Before fix

NAME               INSTALLED BUNDLE                        VERSION               INSTALLED   PROGRESSING   AGE
metallb-operator   metallb-operator.v4.22.0-202607011454   4.22.0-202607011454   True        True          3h

After fix

NAME               INSTALLED BUNDLE                        VERSION               INSTALLED   PROGRESSING   AGE
metallb-operator   metallb-operator.v4.22.0-202607011454   4.22.0-202607011454   True        False         3h

Condition detail after fix

{
    "type": "Progressing",
    "status": "False",
    "reason": "Succeeded",
    "message": "Desired state reached"
}

Test plan

• Built patched operator-controller binary and deployed to OCP 4.22.2 cluster
• Installed MetalLB operator via ClusterExtension
• Verified PROGRESSING=False after successful install (was True before fix)
• Verified INSTALLED=True remains correct
• Verified condition transitions: Progressing=True during rollout → Progressing=False once complete
• Unit tests pass
• E2E tests pass

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9d808271-14b2-4daa-b090-d937cf46dacb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vdurgam10
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @vdurgam10. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@vdurgam10: This pull request references Jira Issue OCPBUGS-97948, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-97948 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug: https://redhat.atlassian.net/browse/OCPBUGS-97948

Summary

• The setStatusProgressing function in common_controller.go defaults the Progressing condition to Status=True with Reason=Succeeded when no error occurs. Per standard Kubernetes condition conventions, Progressing=True means work is still in progress. When the desired state has been reached (no error), Progressing should be False.
• This causes oc get clusterextension to permanently show PROGRESSING=True even when the operator is fully installed and running correctly.
• Fix: default to ConditionFalse (done progressing) and only set ConditionTrue when a non-terminal error triggers a retry.
• Affects: 4.18, 4.19, 4.20, 4.21, 4.22, main (all versions since ClusterExtension v1 API was introduced in 4.18)

Before fix

NAME               INSTALLED BUNDLE                        VERSION               INSTALLED   PROGRESSING   AGE
metallb-operator   metallb-operator.v4.22.0-202607011454   4.22.0-202607011454   True        True          3h

After fix

NAME               INSTALLED BUNDLE                        VERSION               INSTALLED   PROGRESSING   AGE
metallb-operator   metallb-operator.v4.22.0-202607011454   4.22.0-202607011454   True        False         3h

Condition detail after fix

{
   "type": "Progressing",
   "status": "False",
   "reason": "Succeeded",
   "message": "Desired state reached"
}

Test plan

• Built patched operator-controller binary and deployed to OCP 4.22.2 cluster
• Installed MetalLB operator via ClusterExtension
• Verified PROGRESSING=False after successful install (was True before fix)
• Verified INSTALLED=True remains correct
• Verified condition transitions: Progressing=True during rollout → Progressing=False once complete
• Unit tests pass
• E2E tests pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.