Take odrcore 6.9.0 - #175
Merged
Merged
Conversation
6.7.1 to 6.9.0. A document is now drawn in the reader's own light or dark appearance, which the engine learned in 6.8.0, and our loading and error pages follow it too. Printing is unaffected: a dark page still comes out on white paper, which the new test says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W2XM93Raj1jyvUuYmpQrcz
1.41 is submitted but not out, so this build goes under its heading rather than opening a new one. Its engine entry now names 6.9.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W2XM93Raj1jyvUuYmpQrcz
The changelog entries read as what a reader of the app notices, and no longer name the engine or its version. The English store copy picks up the dark appearance. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W2XM93Raj1jyvUuYmpQrcz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.7.1 to 6.9.0, taking 6.8.0 on the way. 6.9.0 was tagged while this was being
written, so the pin is on a real release, not a guess.
What we ask for that we could not before
A document is drawn in the reader's own appearance.
HtmlConfig.colorSchemearrived in 6.8.0 and we set it to
.system, so the page carries both sheets andpicks between them from
prefers-color-scheme. The web view answers that fromthe device setting, which means turning the phone dark while a document is open
costs no second translation - the page swaps itself.
The store copy for 1.35 said documents follow the light and dark appearance.
The engine used to do that on its own; since the HTML rewrite it renders light
unless asked, so this is that sentence becoming true again rather than a new
promise.
A pdf has no dark view -
FileTypeCapabilities.colorSchemesays so for everytype - and stays on white. Nothing to do about that here.
Our own two pages, "loading" and the error, are a web view's default styling,
which is white whatever the device says. They now name
color-schemeso theyare dark alongside the document instead of flashing white in front of it.
The four config options 6.9.0 deprecates (
embedOutline,noDrm,backgroundImageFormat,backgroundImageDpi) are ones we never set.What comes with it, for free
JBIG2Decodeimages decode./Rotatesays, justified text is spaced asthe file asks, and a subset font's glyph names resolve.
.docxkeeps its paragraph spacing, line height and table row heights, anda table follows the style it names.
Checked
xcodebuild teston an iPhone 17 simulator, 51 passing.Two tests are new:
The served page carries a
(prefers-color-scheme: dark)sheet.Printing. Print takes the page the web view is showing, and a dark page
printed as it stands is pale ink on white paper - the words would be gone.
PrintAppearanceTestsrenders a print page out of a web view held in a darkwindow and measures it: the paper comes back white and the ink dark, so the
web view prints in light of its own accord and the menu needs nothing.
It asserts
matchMediafirst, because the trap here is that a web view not ina window ignores an appearance set on it - the first version of this test
passed while never having been dark at all.
I also read the rendered colours back out of a page served in a dark window,
which is where the confidence that this works end to end comes from: body
rgb(1, 4, 9), textrgb(230, 237, 243), the sheetrgb(22, 27, 34), againstwhite and black in light. A screenshot would have been better, but WebKit renders
out of process and a unit test host photographs it blank.
🤖 Generated with Claude Code