Skip to content

chore(git-node): clarify prompt message in promotion script #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Jun 24, 2026
+4 −2
Merged

chore(git-node): clarify prompt message in promotion script #1100

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ccfc48
chore(git-node): clarify prompt message in promotion script
aduh95 Jun 24, 2026
d212661
Apply suggestions from code review
aduh95 Jun 24, 2026
f5b31f7
Apply suggestion from @aduh95
aduh95 Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/promote_release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,11 @@ export default class ReleasePromotion extends Session {
const [commitTitle, ...modifiedFiles] = releaseCommitOnDefaultBranch.trim().split('\n');
await this.validateReleaseCommit(commitTitle);
if (modifiedFiles.some(file => !file.endsWith('.md'))) {
cli.warn('Some modified files are not markdown, that\'s unusual.');
cli.warn(
'Some modified files are not markdown, that\'s unusual. Consider amending the commit.'
);
cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`);
if (await cli.prompt('Consider amending the commit before continuing. Ready to continue?', {
if (await cli.prompt('Ignore and continue anyway?', {
defaultAnswer: false
})) {
break;
Expand Down
Loading