chore(git-node): clarify prompt message in promotion script#1100
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 45 45
Lines 7003 7003
=======================================
Hits 4519 4519
Misses 2484 2484 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Renegade334
approved these changes
Jun 24, 2026
Comment on lines
+543
to
+545
| cli.warn('Some modified files are not markdown, that\'s unusual.'); | ||
| cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`); | ||
| if (await cli.prompt('Consider amending the commit before continuing. Ready to continue?', { | ||
| if (await cli.prompt('Consider amending the commit. Ignore and continue anyway?', { |
Member
There was a problem hiding this comment.
Nit: I would say that this wording changes the intention from "amend then confirm prompt" to "abort then amend", so the sentence Consider amending the commit. might work better appended to the warning message rather than as part of the prompt.
Contributor
Author
There was a problem hiding this comment.
Suggested change
| cli.warn('Some modified files are not markdown, that\'s unusual.'); | |
| cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`); | |
| if (await cli.prompt('Consider amending the commit before continuing. Ready to continue?', { | |
| if (await cli.prompt('Consider amending the commit. Ignore and continue anyway?', { | |
| if (await cli.prompt('Ignore and continue anyway?', { |
aduh95
commented
Jun 24, 2026
aduh95
commented
Jun 24, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
approved these changes
Jun 24, 2026
aduh95
commented
Jun 24, 2026
Renegade334
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #1099, it wasn't very clear that answering Yes would ignore the error, so rephrasing the prompt message to clarify that