Skip to content

chore(git-node): clarify prompt message in promotion script#1100

Merged
aduh95 merged 3 commits into
nodejs:mainfrom
aduh95:no-abort-on-cherry-pick-fail
Jun 24, 2026
Merged

chore(git-node): clarify prompt message in promotion script#1100
aduh95 merged 3 commits into
nodejs:mainfrom
aduh95:no-abort-on-cherry-pick-fail

Conversation

@aduh95

@aduh95 aduh95 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Introduced in #1099, it wasn't very clear that answering Yes would ignore the error, so rephrasing the prompt message to clarify that

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (383db96) to head (f5b31f7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files          45       45           
  Lines        7003     7003           
=======================================
  Hits         4519     4519           
  Misses       2484     2484           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/promote_release.js Outdated
Comment on lines +543 to +545
cli.warn('Some modified files are not markdown, that\'s unusual.');
cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`);
if (await cli.prompt('Consider amending the commit before continuing. Ready to continue?', {
if (await cli.prompt('Consider amending the commit. Ignore and continue anyway?', {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would say that this wording changes the intention from "amend then confirm prompt" to "abort then amend", so the sentence Consider amending the commit. might work better appended to the warning message rather than as part of the prompt.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cli.warn('Some modified files are not markdown, that\'s unusual.');
cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`);
if (await cli.prompt('Consider amending the commit before continuing. Ready to continue?', {
if (await cli.prompt('Consider amending the commit. Ignore and continue anyway?', {
if (await cli.prompt('Ignore and continue anyway?', {

Comment thread lib/promote_release.js Outdated
Comment thread lib/promote_release.js Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Comment thread lib/promote_release.js Outdated
@aduh95 aduh95 merged commit 254ebaa into nodejs:main Jun 24, 2026
10 of 11 checks passed
@aduh95 aduh95 deleted the no-abort-on-cherry-pick-fail branch June 24, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants