Skip to content

chore(git-node): remove abort error in case of fixable error#1099

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:no-abort-on-cherry-pick-fail
Jun 23, 2026
Merged

chore(git-node): remove abort error in case of fixable error#1099
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:no-abort-on-cherry-pick-fail

Conversation

@aduh95

@aduh95 aduh95 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

In the promotion script, the cherry-pick can have error that the releaser wants to fix before continuing. However, if they answer no, the whole process is aborted, which is rarely something the releaser would actually want – and if they do, I guess they'd have to do Ctrl+C from now on.

@aduh95 aduh95 requested a review from RafaelGSS June 23, 2026 16:56
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (07d5ba0) to head (41eab27).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files          45       45           
  Lines        7003     7003           
=======================================
  Hits         4519     4519           
  Misses       2484     2484           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 383db96 into nodejs:main Jun 23, 2026
11 checks passed
@aduh95 aduh95 deleted the no-abort-on-cherry-pick-fail branch June 23, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants