Skip to content

test: cover delimiters inside an async method signature #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DylanPiercey merged 1 commit into from
Aug 12, 2026
Merged

test: cover delimiters inside an async method signature #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 59 additions & 2 deletions ...xtures/attr-method-shorthand-async/__snapshots__/attr-method-shorthand-async.expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,62 @@
│ ├─ closeTagEnd(foo)
╰─ ╰─ tagName "foo"
39╭─
│ ├─ openTagEnd
╰─ ╰─ closeTagEnd(foo)
╰─ ╰─ openTagEnd
40╭─ <button async onClick(value = ")") { await save() }/>
│ ││ │ │ ││ ││ ╰─ openTagEnd:selfClosed "/>"
│ ││ │ │ ││ │╰─ attrMethod.body.value " await save() "
│ ││ │ │ ││ ╰─ attrMethod.body "{ await save() }"
│ ││ │ │ │╰─ attrMethod.params.value "value = \")\""
│ ││ │ │ ╰─ attrMethod.params "(value = \")\")"
│ ││ │ ╰─ attrName "onClick"
│ ││ ╰─ attrMethod:async "async onClick(value = \")\") { await save() }"
│ │╰─ tagName "button"
│ ├─ closeTagEnd(foo)
╰─ ╰─ openTagStart
41├─
42╭─ <button async onClick(v = `a${ ")" }b`) { await save() }/>
│ ││ │ │ ││ ││ ╰─ openTagEnd:selfClosed "/>"
│ ││ │ │ ││ │╰─ attrMethod.body.value " await save() "
│ ││ │ │ ││ ╰─ attrMethod.body "{ await save() }"
│ ││ │ │ │╰─ attrMethod.params.value "v = `a${ \")\" }b`"
│ ││ │ │ ╰─ attrMethod.params "(v = `a${ \")\" }b`)"
│ ││ │ ╰─ attrName "onClick"
│ ││ ╰─ attrMethod:async "async onClick(v = `a${ \")\" }b`) { await save() }"
│ │╰─ tagName "button"
╰─ ╰─ openTagStart
43├─
44╭─ <button async onClick(v = /\)/) { await save() }/>
│ ││ │ │ ││ ││ ╰─ openTagEnd:selfClosed "/>"
│ ││ │ │ ││ │╰─ attrMethod.body.value " await save() "
│ ││ │ │ ││ ╰─ attrMethod.body "{ await save() }"
│ ││ │ │ │╰─ attrMethod.params.value "v = /\\)/"
│ ││ │ │ ╰─ attrMethod.params "(v = /\\)/)"
│ ││ │ ╰─ attrName "onClick"
│ ││ ╰─ attrMethod:async "async onClick(v = /\\)/) { await save() }"
│ │╰─ tagName "button"
╰─ ╰─ openTagStart
45├─
46╭─ <button async onClick(v /* ) */ = 1) { await save() }/>
│ ││ │ │ ││ ││ ╰─ openTagEnd:selfClosed "/>"
│ ││ │ │ ││ │╰─ attrMethod.body.value " await save() "
│ ││ │ │ ││ ╰─ attrMethod.body "{ await save() }"
│ ││ │ │ │╰─ attrMethod.params.value "v /* ) */ = 1"
│ ││ │ │ ╰─ attrMethod.params "(v /* ) */ = 1)"
│ ││ │ ╰─ attrName "onClick"
│ ││ ╰─ attrMethod:async "async onClick(v /* ) */ = 1) { await save() }"
│ │╰─ tagName "button"
╰─ ╰─ openTagStart
47├─
48╭─ <button async onClick<T extends ")">(v: T) { await save() }/>
│ ││ │ │ ││ ││ ││ ╰─ openTagEnd:selfClosed "/>"
│ ││ │ │ ││ ││ │╰─ attrMethod.body.value " await save() "
│ ││ │ │ ││ ││ ╰─ attrMethod.body "{ await save() }"
│ ││ │ │ ││ │╰─ attrMethod.params.value "v: T"
│ ││ │ │ ││ ╰─ attrMethod.params "(v: T)"
│ ││ │ │ │╰─ attrMethod.typeParams.value "T extends \")\""
│ ││ │ │ ╰─ attrMethod.typeParams "<T extends \")\">"
│ ││ │ ╰─ attrName "onClick"
│ ││ ╰─ attrMethod:async "async onClick<T extends \")\">(v: T) { await save() }"
│ │╰─ tagName "button"
╰─ ╰─ openTagStart
49╰─
10 changes: 10 additions & 0 deletions src/__tests__/fixtures/attr-method-shorthand-async/input.marko
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,13 @@ foo async (event) {
}

foo async(event) {}

<button async onClick(value = ")") { await save() }/>

<button async onClick(v = `a${ ")" }b`) { await save() }/>

<button async onClick(v = /\)/) { await save() }/>

<button async onClick(v /* ) */ = 1) { await save() }/>

<button async onClick<T extends ")">(v: T) { await save() }/>