Skip to content

test: cover delimiters inside an async method signature - #238

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-async-shorthand-methods-u5fp34-async-delimiters
Aug 12, 2026
Merged

test: cover delimiters inside an async method signature#238
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-async-shorthand-methods-u5fp34-async-delimiters

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Adds fixtures where a string, template, regex, comment or type parameter inside an async shorthand method's signature contains the characters that delimit it. The parser already handles these; the coverage exists because a consumer scanning the signature by counting delimiters gets them wrong.

@changeset-bot

changeset-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5b22d24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 089eedce-7b8b-4cd0-bbf6-15cdd327c82f

📥 Commits

Reviewing files that changed from the base of the PR and between d648b57 and 5b22d24.

⛔ Files ignored due to path filters (1)
  • src/__tests__/fixtures/attr-method-shorthand-async/__snapshots__/attr-method-shorthand-async.expected.txt is excluded by !**/__snapshots__/** and included by **
📒 Files selected for processing (1)
  • src/__tests__/fixtures/attr-method-shorthand-async/input.marko

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (d648b57) to head (5b22d24).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          34       34           
  Lines        4558     4558           
  Branches      874      874           
=======================================
  Hits         4556     4556           
  Misses          2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Strings, templates, regexes, comments and type params can all contain the
characters that delimit the signature.
@DylanPiercey
DylanPiercey force-pushed the dpiercey-ws-async-shorthand-methods-u5fp34-async-delimiters branch from 079323f to 5b22d24 Compare August 12, 2026 00:21
@DylanPiercey
DylanPiercey merged commit be5fa09 into main Aug 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant