Skip to content

fix(fsapp): avoid premature task finalization #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tomodad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fsapp): avoid premature task finalization #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions frontends/fsapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,18 +702,14 @@ def fail(self, msg):
self._fallback_text(f"❌ {msg}", final=True)


def _make_task_hook(card, task_id, on_final):
"""飞书任务 hook：每轮 patch 卡片状态；结束触发 on_final(raw) 处理附件。"""
def _make_task_hook(card, task_id):
"""飞书任务 hook：只将每轮 summary 更新到任务卡片。"""
def hook(ctx):
try:
parent = getattr(ctx.get("self"), "parent", None)
if getattr(parent, "_fs_active_task_id", None) != task_id:
return
if ctx.get('exit_reason'):
resp = ctx.get('response')
raw = resp.content if hasattr(resp, 'content') else str(resp)
on_final(raw)
elif ctx.get('summary'):
if ctx.get('summary'):
detail = _build_step_detail(ctx.get('response'), ctx.get('tool_calls') or [])
card.step(ctx['summary'], detail)
except Exception as e:
Expand Down Expand Up @@ -761,7 +757,7 @@ def _finish(raw):
await asyncio.to_thread(card.start)
if not hasattr(self.agent, '_turn_end_hooks'):
self.agent._turn_end_hooks = {}
self.agent._turn_end_hooks[hook_key] = _make_task_hook(card, task_id, _finish)
self.agent._turn_end_hooks[hook_key] = _make_task_hook(card, task_id)
self.agent._fs_active_task_id = task_id
dq = self.agent.put_task(f"{FILE_HINT}\n\n{text}", source=self.source, images=images or None)
start = time.time()
Expand Down