fix(fsapp): avoid premature task finalization#686
Open
Tomodad wants to merge 1 commit into
Open
Conversation
Keep task hooks summary-only so turn-end metadata cannot finalize queued work before display queue done. Co-Authored-By: GenericAgent <bot@gaagent.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exit_reasonmetadata from finalizing queued work earlydisplay_queue'sdoneitem as the normal task-finalization pathFixes #685.
Root cause
_make_task_hookreceived_finishason_finaland invoked it whenever a hook context containedexit_reason. That metadata can describe an intermediate agent turn rather than completion of the queued Feishu task, so_finishcould setresult["sent"]before the display queue published its realdoneitem.Change
Remove the final callback from
_make_task_hookand let the hook handle onlysummary -> card.step. The existing display-queuedone -> _finishpath and timeout/stop/error failure paths are unchanged.Verification
exit_reasonfinalization while preserving summary updatesexit_reason, repeated calls, inactive task IDs, and formatting inputspython -m py_compile frontends/fsapp.pygit diff --check