Skip to content

node: include previous state/result in update events #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nuclearcat wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −5
Draft

node: include previous state/result in update events #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions api/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,8 +1513,8 @@ async def get_telemetry_anomalies(

# -----------------------------------------------------------------------------
# Nodes
def _get_node_event_data(operation, node, is_hierarchy=False):
return {
def _get_node_event_data(operation, node, is_hierarchy=False, previous=None):
data = {
"op": operation,
"id": str(node.id),
"kind": node.kind,
Expand All @@ -1527,6 +1527,14 @@ def _get_node_event_data(operation, node, is_hierarchy=False):
"data": node.data,
"is_hierarchy": is_hierarchy,
}
if previous is not None:
# Carry the pre-update state/result so event consumers (e.g. the
# pipeline scheduler) can act on the transition INTO a state rather
# than re-firing on every update that keeps the node in the same
# matching state. See kernelci-core#2912.
data["previous_state"] = previous.get("state")
data["previous_result"] = previous.get("result")
return data


async def translate_null_query_params(query_params: dict):
Expand Down Expand Up @@ -1784,8 +1792,9 @@ async def put_node(
new_node_def.processed_by_kcidb_bridge = False

# Update node in the DB
previous = {"state": node_from_id.state, "result": node_from_id.result}
obj = await db.update(new_node_def)
data = _get_node_event_data("updated", obj)
data = _get_node_event_data("updated", obj, previous=previous)
attributes = {}
if data.get("owner", None):
attributes["owner"] = data["owner"]
Expand Down Expand Up @@ -1866,8 +1875,9 @@ async def patch_node(
new_node_def.processed_by_kcidb_bridge = False

# Update node in the DB
previous = {"state": node_from_id.state, "result": node_from_id.result}
obj = await db.update(new_node_def)
data = _get_node_event_data("updated", obj)
data = _get_node_event_data("updated", obj, previous=previous)
attributes = {}
if data.get("owner", None):
attributes["owner"] = data["owner"]
Expand Down Expand Up @@ -1960,8 +1970,9 @@ async def put_nodes(
treeid = node_from_id.treeid

await _set_node_ownership_recursively(user, nodes, submitter, treeid)
previous = {"state": node_from_id.state, "result": node_from_id.result}
obj_list = await db.create_hierarchy(nodes, Node)
data = _get_node_event_data("updated", obj_list[0], True)
data = _get_node_event_data("updated", obj_list[0], True, previous=previous)
attributes = {}
if data.get("owner", None):
attributes["owner"] = data["owner"]
Expand Down