node: include previous state/result in update events#702
Draft
nuclearcat wants to merge 1 commit into
Draft
Conversation
Node update events were published on every change carrying only the node's current values. Consumers such as the pipeline scheduler match on those values alone, with no way to tell an actual state transition apart from an unrelated update (e.g. adding an artifact or bumping a timeout on a node that is already in a matching state). Add previous_state and previous_result to the payload of "updated" events emitted by put_node, patch_node and put_nodes, so consumers can act on the transition into a state rather than on every update. This is the API-side half of the fix for duplicate child-node creation: an audit of production found identical jobs (same parent, name, runtime and platform, same retry_counter) created seconds apart, recreated each time the parent node was updated while staying in a matching state. Addresses kernelci/kernelci-core#2912 Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node update events were published on every change carrying only the node's current values. Consumers such as the pipeline scheduler match on those values alone, with no way to tell an actual state transition apart from an unrelated update (e.g. adding an artifact or bumping a timeout on a node that is already in a matching state).
Add previous_state and previous_result to the payload of "updated" events emitted by put_node, patch_node and put_nodes, so consumers can act on the transition into a state rather than on every update.
This is the API-side half of the fix for duplicate child-node creation: an audit of production found identical jobs (same parent, name, runtime and platform, same retry_counter) created seconds apart, recreated each time the parent node was updated while staying in a matching state.
Addresses kernelci/kernelci-core#2912