-
Notifications
You must be signed in to change notification settings - Fork 331
Rename pipeline sqlclient-package -> sqlclient-ci-package #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulmedynski
wants to merge
1
commit into
main
Choose a base branch
from
dev/paul/sqlclient-ci-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−30
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,35 +7,27 @@ | |
| # This pipeline builds all packages using the build.proj Pack target with ReferenceType=Package, | ||
| # then publishes the resulting .nupkg and .snupkg files as a single pipeline artifact. | ||
| # | ||
| # It runs: | ||
| # - On pushes to GitHub main and ADO internal/main (batched) | ||
| # - Nightly at 00:00 UTC on both branches | ||
| # It runs nightly at 00:20 UTC on GitHub dotnet/SqlClient main and ADO.Net dotnet-sqlclient | ||
| # internal/main. | ||
| # | ||
| # On internal/main the strong-name signing key is downloaded and used to sign assemblies during the | ||
| # build. | ||
| # | ||
| # GOTCHA: This pipeline definition is triggered by GitHub _and_ ADO CI. We distinguish the two via | ||
| # branch filters: | ||
| # GOTCHA: This pipeline definition is triggered by GitHub _and_ ADO.NET CI. We distinguish the two | ||
| # via branch filters: | ||
| # | ||
| # - Only the GitHub repo has a 'main' branch. | ||
| # - Only the ADO repo has an 'internal/main' branch. | ||
|
|
||
| name: $(DayOfYear)$(Rev:rr) | ||
|
|
||
| # Do not trigger this pipeline for PRs. | ||
| # Do not trigger this pipeline for PRs or pushes. | ||
| pr: none | ||
| trigger: none | ||
|
|
||
| # Trigger on pushes to main and internal/main, batching concurrent commits. | ||
| trigger: | ||
| batch: true | ||
| branches: | ||
| include: | ||
| - main | ||
| - internal/main | ||
|
|
||
| # Nightly schedule at 00:00 UTC. | ||
| # Nightly schedule at 00:20 UTC. | ||
| schedules: | ||
| - cron: '0 0 * * *' | ||
| - cron: '20 0 * * *' | ||
| displayName: Nightly Build | ||
| branches: | ||
| include: | ||
|
|
@@ -92,13 +84,13 @@ variables: | |
| # downloaded by DownloadSecureFile@1; on public builds it expands to empty. | ||
| - name: signingKeyArg | ||
| ${{ if eq(variables.isInternalBuild, true) }}: | ||
| value: '-p:SigningKeyPath="$(keyFile.secureFilePath)"' | ||
| value: -p:SigningKeyPath="$(driverKeyFile.secureFilePath)" | ||
| ${{ else }}: | ||
| value: '' | ||
|
|
||
| jobs: | ||
| - job: pack_all_packages | ||
| displayName: Pack All Packages | ||
| - job: build_nuget_packages | ||
| displayName: Build NuGet Packages | ||
|
|
||
| pool: | ||
| ${{ if eq(variables.isInternalBuild, true) }}: | ||
|
|
@@ -124,29 +116,29 @@ jobs: | |
| # Restore dotnet local tools (pwsh, apicompat, etc.). | ||
| - template: /eng/pipelines/common/steps/restore-dotnet-tools.yml@self | ||
|
|
||
| # Clean any pre-existing .nupkg / .snupkg files from the packages/ directory | ||
| # to ensure we only publish packages produced by this run. | ||
| # Clean any pre-existing .nupkg / .snupkg files from the packages/ directory to ensure we only | ||
| # publish packages produced by this run. | ||
| - pwsh: | | ||
| Write-Host 'Cleaning packages/ directory...' | ||
| Remove-Item -Force "$(Build.SourcesDirectory)/packages/*.nupkg" -ErrorAction SilentlyContinue | ||
| Remove-Item -Force "$(Build.SourcesDirectory)/packages/*.snupkg" -ErrorAction SilentlyContinue | ||
| Write-Host 'Done.' | ||
| displayName: Clean packages/ directory | ||
| displayName: Clean Packages Directory | ||
|
|
||
| # On internal builds, download the strong-name signing key. | ||
| - ${{ if eq(variables.isInternalBuild, true) }}: | ||
| - task: DownloadSecureFile@1 | ||
| displayName: Download Signing Key | ||
| displayName: Download Driver Signing Key | ||
| inputs: | ||
| secureFile: netfxKeypair.snk | ||
| name: keyFile | ||
| name: driverKeyFile | ||
|
|
||
| # Run the Pack target via build.proj. | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: build.proj - Pack (ReferenceType=Package) | ||
| displayName: Build & Pack | ||
| inputs: | ||
| command: build | ||
| projects: '$(Build.SourcesDirectory)/build.proj' | ||
| projects: $(Build.SourcesDirectory)/build.proj | ||
| arguments: >- | ||
| -t:Pack | ||
| -p:Configuration=${{ parameters.buildConfiguration }} | ||
|
|
@@ -161,12 +153,12 @@ jobs: | |
| Write-Host 'Packages produced:' | ||
| Get-ChildItem "$(Build.SourcesDirectory)/packages/*.nupkg" -ErrorAction SilentlyContinue | Format-Table Name, Length -AutoSize -Wrap | ||
| Get-ChildItem "$(Build.SourcesDirectory)/packages/*.snupkg" -ErrorAction SilentlyContinue | Format-Table Name, Length -AutoSize -Wrap | ||
| displayName: List produced packages | ||
| displayName: List Packages | ||
|
|
||
| # Publish all .nupkg and .snupkg files from packages/ as a pipeline artifact. | ||
| - task: PublishPipelineArtifact@1 | ||
| displayName: Publish NuGet Packages | ||
| displayName: Publish Packages | ||
| inputs: | ||
| targetPath: '$(Build.SourcesDirectory)/packages' | ||
| artifactName: Packages | ||
| targetPath: $(Build.SourcesDirectory)/packages | ||
| artifactName: SqlClient-Driver-Packages | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will be a well-known artifact name that many downstream CI pipelines use. |
||
| publishLocation: pipeline | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new CI pipelines will be schedule-only for now. We can decide if/when we want them to run on PR and/or push triggers, for example maybe we want checks during or after sync PRs to ADO.Net.