Rename pipeline sqlclient-package -> sqlclient-ci-package#4454
Open
paulmedynski wants to merge 1 commit into
Open
Rename pipeline sqlclient-package -> sqlclient-ci-package#4454paulmedynski wants to merge 1 commit into
paulmedynski wants to merge 1 commit into
Conversation
- Other minor cleanup for consistent stage/job/step names.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ADO pipeline definition for the package CI build, primarily aligning naming/display metadata with the “ci-package” transition and adjusting when/how the pipeline runs.
Changes:
- Updates pipeline documentation/comments and renames the primary job/display names for consistency.
- Adjusts pipeline triggering behavior to disable push/PR triggers and rely on a nightly schedule (00:20 UTC).
- Renames the published artifact from a generic name to
SqlClient-Driver-Packages.
Comments suppressed due to low confidence (3)
eng/pipelines/ci/package/sqlclient-ci-package-pipeline.yml:26
- The PR description doesn’t mention that CI push triggers are being removed. Switching to
trigger: noneis a behavior change (pipeline will no longer run on pushes tomain/internal/main) and should either be called out in the PR description or reverted if unintentional.
eng/pipelines/ci/package/sqlclient-ci-package-pipeline.yml:11 - The header comment uses "ADO.Net" but elsewhere in this file uses "ADO.NET". For consistency (and the official branding), use "ADO.NET" everywhere.
eng/pipelines/ci/package/sqlclient-ci-package-pipeline.yml:17 - This comment says the pipeline is triggered by "GitHub and ADO.NET CI", but the YAML now has
trigger: none(scheduled only). The wording is misleading after this change; consider rephrasing to reflect that it runs via schedule in both projects/branches.
paulmedynski
added
the
Area\Engineering
paulmedynski
marked this pull request as ready for review
July 17, 2026 15:30
paulmedynski
enabled auto-merge (squash)
July 17, 2026 15:30
paulmedynski
commented
Jul 17, 2026
| pr: none | ||
| trigger: none | ||
|
|
||
| # Trigger on pushes to main and internal/main, batching concurrent commits. |
Contributor
Author
There was a problem hiding this comment.
The new CI pipelines will be schedule-only for now. We can decide if/when we want them to run on PR and/or push triggers, for example maybe we want checks during or after sync PRs to ADO.Net.
| targetPath: '$(Build.SourcesDirectory)/packages' | ||
| artifactName: Packages | ||
| targetPath: $(Build.SourcesDirectory)/packages | ||
| artifactName: SqlClient-Driver-Packages |
Contributor
Author
There was a problem hiding this comment.
This will be a well-known artifact name that many downstream CI pipelines use.
cheenamalhotra
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sqlclient-packagepipeline tosqlclient-ci-pipelineto match our transition plan.Testing
The Azure DevOps pipeline configs have already been created and/or renamed/updated, and all now expect the new pipeline path/filename.