Gate messages to epoch once the epoch is sealed - #513
Open
samliok wants to merge 2 commits into
Open
Conversation
yacovm
reviewed
Aug 14, 2026
| } | ||
|
|
||
| return err | ||
| if block.SealingBlockInfo() != nil && block.SealingBlockInfo().PrevSealingBlockHash != [32]byte{} { |
Collaborator
There was a problem hiding this comment.
we have the method onEpochChange in instance.go, can't we just define the variable there?
yacovm
reviewed
Aug 14, 2026
|
|
||
| func (i *Instance) handleValidatorMessage(msg *common.Message, from common.NodeID) error { | ||
| // we only want to process replication requests if the epoch is sealed | ||
| if i.cs.lastSealedEpoch == i.e.Metadata().Epoch { |
Collaborator
There was a problem hiding this comment.
why ==? What if it's a replication request for a previous epoch? Shouldn't we serve it as well?
yacovm
reviewed
Aug 14, 2026
| return nil | ||
| } | ||
|
|
||
| switch { |
Collaborator
There was a problem hiding this comment.
if the message handles one of the cases then shouldn't we return?
yacovm
reviewed
Aug 14, 2026
| return nil | ||
| } | ||
|
|
||
| switch { |
Collaborator
There was a problem hiding this comment.
why do we have auxiliary info disseminated separately from the approval?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.