Stop indexing and gate messages once the epoch is sealed - #503
Closed
samliok wants to merge 3 commits into
Closed
Conversation
samliok
marked this pull request as ready for review
August 13, 2026 22:30
yacovm
reviewed
Aug 13, 2026
| if err := e.Storage.Index(e.finishCtx, block, finalization); err != nil { | ||
| return err | ||
| // index only if the epoch is not sealed | ||
| if !e.isEpochSealed() { |
Collaborator
There was a problem hiding this comment.
but don't we already enforce that at the instance level? Why do this here too?
Collaborator
Author
There was a problem hiding this comment.
yea agreed it can be removed
yacovm
reviewed
Aug 13, 2026
| @@ -166,7 +166,7 @@ func (e *Epoch) HandleMessage(msg *common.Message, from common.NodeID) error { | |||
| } | |||
|
|
|||
| _, known := e.validatorsToPKs[string(from)] | |||
Collaborator
There was a problem hiding this comment.
I think we should enforce this externally, not internally.
Collaborator
Author
There was a problem hiding this comment.
agreed, should this be done in a separate pr though?
Collaborator
There was a problem hiding this comment.
but if we do that in a separate PR then we don't do it here...
Collaborator
Author
|
closed with #513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of the cleanup-instance branch.
Two related fixes for behavior after an epoch seals:
HandleMessagenow treats every sender like a non-validator once the epoch is sealed, so only replication requests are served.indexFinalizationno longer indexes blocks after the epoch is sealed, though it still tracks the last block and progresses rounds.