Skip to content

Clean up tests. #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leerho merged 1 commit into from
Jul 18, 2026
Merged

Clean up tests. #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/test/java/org/apache/datasketches/common/positional/PositionalSegmentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@
import static org.testng.Assert.assertEquals;

import java.lang.foreign.MemorySegment;
import java.util.List;

import org.testng.annotations.Test;
import org.testng.collections.Lists;

public class PositionalSegmentTest {

Expand Down
2 changes: 0 additions & 2 deletions src/test/java/org/apache/datasketches/common/positional/PositionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;

import java.lang.foreign.MemorySegment;

import org.testng.annotations.Test;

/**
Expand Down
11 changes: 5 additions & 6 deletions src/test/java/org/apache/datasketches/count/CountMinSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,15 @@

package org.apache.datasketches.count;

import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertThrows;
import static org.testng.Assert.assertTrue;

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.SketchesException;
import org.testng.annotations.Test;

import java.io.ByteArrayOutputStream;
import java.lang.annotation.Repeatable;
import java.nio.ByteBuffer;

import static org.testng.Assert.*;

public class CountMinSketchTest {

@Test
Expand Down
3 changes: 0 additions & 3 deletions src/test/java/org/apache/datasketches/fdt/FdtSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
import java.util.List;

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.fdt.FdtSketch;
import org.apache.datasketches.fdt.Group;
import org.apache.datasketches.fdt.PostProcessor;
import org.apache.datasketches.tuple.TupleSketchIterator;
import org.apache.datasketches.tuple.strings.ArrayOfStringsSummary;
import org.testng.annotations.Test;
Expand Down
1 change: 0 additions & 1 deletion src/test/java/org/apache/datasketches/fdt/GroupTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import static org.testng.Assert.assertEquals;

import org.apache.datasketches.fdt.Group;
import org.testng.annotations.Test;

/**
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/org/apache/datasketches/filters/bloomfilter/BloomFilterBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.filters.bloomfilter.BloomFilter;
import org.apache.datasketches.filters.bloomfilter.BloomFilterBuilder;
import org.testng.annotations.Test;

public class BloomFilterBuilderTest {
Expand Down
5 changes: 1 addition & 4 deletions src/test/java/org/apache/datasketches/filters/bloomfilter/BloomFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,14 @@
import static org.testng.Assert.assertThrows;
import static org.testng.Assert.assertTrue;

import java.lang.foreign.Arena;
import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.Family;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.SketchesReadOnlyException;
import org.apache.datasketches.filters.bloomfilter.BloomFilter;
import org.apache.datasketches.filters.bloomfilter.BloomFilterBuilder;
import org.testng.annotations.Test;

import java.lang.foreign.Arena;

public class BloomFilterTest {

@Test
Expand Down
4 changes: 1 addition & 3 deletions src/test/java/org/apache/datasketches/filters/bloomfilter/DirectBitArrayRTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,9 @@

import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.positional.PositionalSegment;
import org.apache.datasketches.filters.bloomfilter.DirectBitArrayR;
import org.apache.datasketches.filters.bloomfilter.HeapBitArray;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.SketchesReadOnlyException;
import org.apache.datasketches.common.positional.PositionalSegment;
import org.testng.annotations.Test;

public class DirectBitArrayRTest {
Expand Down
10 changes: 1 addition & 9 deletions src/test/java/org/apache/datasketches/filters/bloomfilter/DirectBitArrayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,25 +19,17 @@

package org.apache.datasketches.filters.bloomfilter;

import static java.lang.foreign.ValueLayout.JAVA_BYTE;
import static java.lang.foreign.ValueLayout.JAVA_CHAR_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_DOUBLE_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_FLOAT_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_INT_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_LONG_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_SHORT_UNALIGNED;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertThrows;
import static org.testng.Assert.assertTrue;

import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.positional.PositionalSegment;
import org.apache.datasketches.filters.bloomfilter.BitArray;
import org.apache.datasketches.filters.bloomfilter.DirectBitArray;
import org.apache.datasketches.filters.bloomfilter.HeapBitArray;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.positional.PositionalSegment;
import org.testng.annotations.Test;

public class DirectBitArrayTest {
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/org/apache/datasketches/filters/bloomfilter/HeapBitArrayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@

import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.positional.PositionalSegment;
import org.apache.datasketches.filters.bloomfilter.HeapBitArray;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.positional.PositionalSegment;
import org.testng.annotations.Test;

public class HeapBitArrayTest {
Expand Down
1 change: 0 additions & 1 deletion src/test/java/org/apache/datasketches/frequencies/HashMapStressTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

package org.apache.datasketches.frequencies;

import org.apache.datasketches.frequencies.ReversePurgeLongHashMap;
import org.apache.datasketches.hash.MurmurHash3;
//import org.testng.annotations.Test;

Expand Down
7 changes: 2 additions & 5 deletions src/test/java/org/apache/datasketches/frequencies/ItemsSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,14 @@
import static org.testng.Assert.fail;

import java.lang.foreign.MemorySegment;
import org.testng.Assert;
import org.testng.annotations.Test;

import org.apache.datasketches.common.ArrayOfLongsSerDe;
import org.apache.datasketches.common.ArrayOfStringsSerDe;
import org.apache.datasketches.common.ArrayOfUtf16StringsSerDe;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.frequencies.ErrorType;
import org.apache.datasketches.frequencies.FrequentItemsSketch;
import org.apache.datasketches.frequencies.ReversePurgeItemHashMap;
import org.apache.datasketches.frequencies.FrequentItemsSketch.Row;
import org.testng.Assert;
import org.testng.annotations.Test;

public class ItemsSketchTest {

Expand Down
8 changes: 2 additions & 6 deletions src/test/java/org/apache/datasketches/frequencies/LongsSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,12 @@
import static org.testng.Assert.fail;

import java.lang.foreign.MemorySegment;
import org.testng.Assert;
import org.testng.annotations.Test;

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.Util;
import org.apache.datasketches.frequencies.ErrorType;
import org.apache.datasketches.frequencies.FrequentLongsSketch;
import org.apache.datasketches.frequencies.PreambleUtil;
import org.apache.datasketches.frequencies.ReversePurgeLongHashMap;
import org.apache.datasketches.frequencies.FrequentLongsSketch.Row;
import org.testng.Assert;
import org.testng.annotations.Test;

public class LongsSketchTest {

Expand Down
1 change: 0 additions & 1 deletion src/test/java/org/apache/datasketches/frequencies/ReversePurgeLongHashMapTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import static org.testng.Assert.assertNull;

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.frequencies.ReversePurgeLongHashMap;
import org.testng.annotations.Test;

public class ReversePurgeLongHashMapTest {
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/org/apache/datasketches/frequencies/SerDeCompatibilityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@

import org.apache.datasketches.common.ArrayOfItemsSerDe;
import org.apache.datasketches.common.ArrayOfLongsSerDe;
import org.apache.datasketches.frequencies.FrequentItemsSketch;
import org.apache.datasketches.frequencies.FrequentLongsSketch;
import org.testng.Assert;
import org.testng.annotations.Test;

Expand Down
4 changes: 0 additions & 4 deletions src/test/java/org/apache/datasketches/hash/MurmurHash3FFMTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,8 @@
package org.apache.datasketches.hash;

import static java.lang.foreign.ValueLayout.JAVA_BYTE;
import static java.lang.foreign.ValueLayout.JAVA_CHAR_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_DOUBLE_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_FLOAT_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_INT_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_LONG_UNALIGNED;
import static java.lang.foreign.ValueLayout.JAVA_SHORT_UNALIGNED;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/org/apache/datasketches/hll/AuxHashMapTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
import static org.testng.Assert.fail;

import org.apache.datasketches.common.SketchesStateException;
import org.apache.datasketches.hll.HeapAuxHashMap;
import org.apache.datasketches.hll.PairIterator;
import org.testng.annotations.Test;

/**
Expand Down
10 changes: 2 additions & 8 deletions src/test/java/org/apache/datasketches/hll/BaseHllSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,11 @@
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;

import org.apache.datasketches.hll.BaseHllSketch;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.PreambleUtil;
import org.apache.datasketches.hll.TgtHllType;
import org.apache.datasketches.hll.HllUnion;
import org.testng.annotations.Test;

import java.lang.foreign.MemorySegment;

import java.nio.ByteBuffer;

import org.testng.annotations.Test;

/**
* @author Lee Rhodes
*
Expand Down
5 changes: 0 additions & 5 deletions src/test/java/org/apache/datasketches/hll/CouponListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@

import java.lang.foreign.MemorySegment;

import org.apache.datasketches.hll.AbstractCoupons;
import org.apache.datasketches.hll.CurMode;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.PairIterator;
import org.apache.datasketches.hll.TgtHllType;
import org.testng.annotations.Test;

/**
Expand Down
10 changes: 0 additions & 10 deletions src/test/java/org/apache/datasketches/hll/DirectAuxHashMapTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,6 @@
import java.util.HashMap;

import org.apache.datasketches.common.SketchesStateException;
import org.apache.datasketches.hll.AbstractHllArray;
import org.apache.datasketches.hll.AuxHashMap;
import org.apache.datasketches.hll.DirectAuxHashMap;
import org.apache.datasketches.hll.DirectHllArray;
import org.apache.datasketches.hll.HeapAuxHashMap;
import org.apache.datasketches.hll.HllArray;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.HllUtil;
import org.apache.datasketches.hll.PairIterator;
import org.apache.datasketches.hll.TgtHllType;
import org.testng.annotations.Test;

/**
Expand Down
4 changes: 0 additions & 4 deletions src/test/java/org/apache/datasketches/hll/DirectCouponListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
import java.lang.foreign.Arena;
import java.lang.foreign.MemorySegment;

import org.apache.datasketches.hll.AbstractCoupons;
import org.apache.datasketches.hll.CurMode;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.TgtHllType;
import org.testng.annotations.Test;

/**
Expand Down
6 changes: 0 additions & 6 deletions src/test/java/org/apache/datasketches/hll/DirectHllSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.SketchesReadOnlyException;
import org.apache.datasketches.hll.AbstractHllArray;
import org.apache.datasketches.hll.CurMode;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.IntMemorySegmentPairIterator;
import org.apache.datasketches.hll.PairIterator;
import org.apache.datasketches.hll.TgtHllType;
import org.testng.annotations.Test;

/**
Expand Down
7 changes: 1 addition & 6 deletions src/test/java/org/apache/datasketches/hll/DirectUnionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,8 @@

import java.lang.foreign.MemorySegment;

import org.testng.annotations.Test;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.HllUtil;
import org.apache.datasketches.hll.RelativeErrorTables;
import org.apache.datasketches.hll.TgtHllType;
import org.apache.datasketches.hll.HllUnion;
import org.testng.annotations.Test;

/**
* @author Lee Rhodes
Expand Down
5 changes: 0 additions & 5 deletions src/test/java/org/apache/datasketches/hll/HllArrayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.SketchesStateException;
import org.apache.datasketches.hll.AbstractHllArray;
import org.apache.datasketches.hll.HllArray;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.TgtHllType;
import org.apache.datasketches.hll.HllUnion;
import org.testng.annotations.Test;

/**
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/apache/datasketches/hll/HllSketchMergeOrderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public void testDataSketchHLLMergeOrderDependency() {
* @param limit the upper limit, exclusive
* @return the loaded sketch
*/
private HllSketch createUniquePowerSeriesSketch(final long baseValue, final int ppo, final long limit) {
private static HllSketch createUniquePowerSeriesSketch(final long baseValue, final int ppo, final long limit) {
final HllSketch sketch = new HllSketch(LgK);
int count = 0;
long lastp = 0;
Expand All @@ -97,7 +97,7 @@ private HllSketch createUniquePowerSeriesSketch(final long baseValue, final int
/**
* Merges three sketches in the specified order and returns the composite estimate
*/
private double mergeThreeSketches(final HllSketch s1, final HllSketch s2, final HllSketch s3) {
private static double mergeThreeSketches(final HllSketch s1, final HllSketch s2, final HllSketch s3) {
final HllUnion union = new HllUnion(LgK);

union.update(s1);
Expand Down
10 changes: 0 additions & 10 deletions src/test/java/org/apache/datasketches/hll/HllSketchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,6 @@
import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.hll.AbstractCoupons;
import org.apache.datasketches.hll.AbstractHllArray;
import org.apache.datasketches.hll.AuxHashMap;
import org.apache.datasketches.hll.CurMode;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.HllSketchImpl;
import org.apache.datasketches.hll.HllUtil;
import org.apache.datasketches.hll.PreambleUtil;
import org.apache.datasketches.hll.TgtHllType;
import org.apache.datasketches.hll.HllUnion;
import org.testng.annotations.Test;

/**
Expand Down
4 changes: 0 additions & 4 deletions src/test/java/org/apache/datasketches/hll/PreambleUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@
import java.lang.foreign.MemorySegment;

import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.hll.CurMode;
import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.PreambleUtil;
import org.apache.datasketches.hll.TgtHllType;
import org.testng.annotations.Test;

/**
Expand Down
4 changes: 1 addition & 3 deletions src/test/java/org/apache/datasketches/hll/SizeAndModeTransitions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@

import java.lang.foreign.MemorySegment;

import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.TgtHllType;
import org.testng.annotations.Test;

public class SizeAndModeTransitions {
Expand All @@ -38,7 +36,7 @@ public void checkHLL8with_withoutSeg() {
checkHLL8Heap(false);
}

private void checkHLL8Heap(final boolean withSeg) {
private static void checkHLL8Heap(final boolean withSeg) {
final TgtHllType tgtHllType = TgtHllType.HLL_8;
final int lgK = 10;
final int N = 97;
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/org/apache/datasketches/hll/ToFromByteArrayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@

import java.lang.foreign.MemorySegment;

import org.apache.datasketches.hll.HllSketch;
import org.apache.datasketches.hll.TgtHllType;
import org.testng.annotations.Test;

/**
Expand Down
Loading
Loading