Skip to content

Clean up tests.#743

Open
leerho wants to merge 1 commit into
mainfrom
cleanup_tests
Open

Clean up tests.#743
leerho wants to merge 1 commit into
mainfrom
cleanup_tests

Conversation

@leerho

@leerho leerho commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • All these changes are in the src/test/java tree.
  • The vast majority of these changes are removing unused imports.
  • There are a few methods that needed to be made static.
  • And a few places where it made sense to add "@SuppressWarnings("unused")"
  • I found one bug among the tests, which I fixed.
  • Other than the one bug, there were absolutely no logic changes.

I realize this is a lot of files, but it is all minutiae.

github-advanced-security[bot]
github-advanced-security AI found potential problems Jul 17, 2026
View reviewed changes
Comment thread src/test/java/org/apache/datasketches/quantiles/DoublesMiscTest.java
* @param o object to print
*/
private static void println(final Object o) {
static void println(final Object o) {

@leerho leerho Jul 17, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this suggestion. The bot does not understand the latent purpose of this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes
@proost proost proost approved these changes
@freakyzoidberg freakyzoidberg Awaiting requested review from freakyzoidberg
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leerho @tisonkun @proost @github-advanced-security