fix(disability_registry): hide misleading 'No Disability' status smart button (#1129)

spp_disability_registry/README.rst

@@ -52,6 +52,16 @@ Key Features
 Changelog
 =========
 
+19.0.3.0.1
+~~~~~~~~~~
+
+- fix(disability_registry): remove the "Disability / No Disability"
+  status smart button from the registrant form. It read "No Disability"
+  whenever no approved assessment crossed the WG/CFM threshold, which
+  was misleading for people who had an approved assessment recording an
+  impairment — the full status is already shown on the Disability tab
+  and its Assessment History (#1129)
+
 19.0.3.0.0
 ~~~~~~~~~~
 

spp_disability_registry/__manifest__.py

@@ -1,6 +1,6 @@
 {
     "name": "OpenSPP Disability Registry",
-    "version": "19.0.3.0.0",
+    "version": "19.0.3.0.1",
     "category": "OpenSPP",
     "summary": "Disability assessment and registry management for social protection",
     "author": "OpenSPP.org",

spp_disability_registry/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.3.0.1
+
+- fix(disability_registry): remove the "Disability / No Disability" status smart button from the registrant form. It read "No Disability" whenever no approved assessment crossed the WG/CFM threshold, which was misleading for people who had an approved assessment recording an impairment — the full status is already shown on the Disability tab and its Assessment History (#1129)
+
 ### 19.0.3.0.0
 
 - feat(disability_registry): age-driven assessment type selection with manual override (#1050)

spp_disability_registry/static/description/index.html

@@ -402,6 +402,17 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
 </div>
 </div>
 <div class="section" id="section-1">
+<h1>19.0.3.0.1</h1>
+<ul class="simple">
+<li>fix(disability_registry): remove the “Disability / No Disability”
+status smart button from the registrant form. It read “No Disability”
+whenever no approved assessment crossed the WG/CFM threshold, which
+was misleading for people who had an approved assessment recording an
+impairment — the full status is already shown on the Disability tab
+and its Assessment History (#1129)</li>
+</ul>
+</div>
+<div class="section" id="section-2">
 <h1>19.0.3.0.0</h1>
 <ul class="simple">
 <li>feat(disability_registry): age-driven assessment type selection with
@@ -418,15 +429,15 @@ <h1>19.0.3.0.0</h1>
 registry (#1022)</li>
 </ul>
 </div>
-<div class="section" id="section-2">
+<div class="section" id="section-3">
 <h1>19.0.2.0.1</h1>
 <ul class="simple">
 <li>fix(views): apply <tt class="docutils literal">spp_registry.x2many_no_padding</tt> widget to the
 disability assessments list on registrant forms, and hide the table
 when empty (showing a muted info line instead) (#943).</li>
 </ul>
 </div>
-<div class="section" id="section-3">
+<div class="section" id="section-4">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_disability_registry/views/registrant_views.xml

@@ -7,31 +7,6 @@
         <field name="inherit_id" ref="spp_registry.view_individuals_form" />
         <field name="arch" type="xml">
             <xpath expr="//div[@name='button_box']" position="inside">
-                <!-- Disability Status Smart Button -->
-                <button
-                    name="action_view_disability_assessments"
-                    type="object"
-                    class="oe_stat_button"
-                    icon="fa-wheelchair"
-                    invisible="not is_registrant or is_group"
-                >
-                    <div class="o_stat_info">
-                        <field
-                            name="disability_severity_id"
-                            class="o_stat_text"
-                            invisible="not has_disability"
-                            options="{'no_open': True}"
-                        />
-                        <span
-                            class="o_stat_text"
-                            invisible="not has_disability"
-                        >Disability</span>
-                        <span
-                            class="o_stat_text text-muted"
-                            invisible="has_disability"
-                        >No Disability</span>
-                    </div>
-                </button>
                 <!-- Assessment Count Button -->
                 <button
                     name="action_view_disability_assessments"