fix(disability_registry): hide misleading 'No Disability' status smart button (#1129)

[emjay0921]

Why is this change needed?

The registrant form showed a Disability / No Disability status smart button that read "No Disability" whenever no approved assessment crossed the WG/CFM threshold. This was misleading for people who did have an approved assessment recording an impairment — the button contradicted the data on the Disability tab.

How was the change implemented?

Removed the smart button from the registrant form view (spp_disability_registry/views/registrant_views.xml). The full disability status remains visible on the Disability tab and its Assessment History, which is the accurate source.

New unit tests

None — this is a view-only removal; existing tests continue to cover the disability status logic.

Unit tests executed by the author

Module test suite (spp_disability_registry) passes locally.

How to test manually

1. Install spp_disability_registry.
2. Open a registrant form with an approved assessment recording an impairment.
3. Confirm the misleading "No Disability" smart button is gone.
4. Confirm the Disability tab and Assessment History still show the correct status.

Related links

OP#1129

[gemini-code-assist]

Code Review

This pull request removes the "Disability / No Disability" status smart button from the registrant form view to prevent misleading information when no approved assessment crosses the threshold. It also bumps the module version to 19.0.3.0.1 and updates the changelog files accordingly. I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.84%. Comparing base (fd1eb1b) to head (ef43d8b).

Additional details and impacted files

@@            Coverage Diff             @@
##             19.0     #296      +/-   ##
==========================================
+ Coverage   68.23%   68.84%   +0.60%     
==========================================
  Files         157      168      +11     
  Lines       13420    13994     +574     
==========================================
+ Hits         9157     9634     +477     
- Misses       4263     4360      +97     

Flag	Coverage Δ
spp_base_common	90.26% <ø> (ø)
spp_disability_registry	83.87% <ø> (?)
spp_programs	65.27% <ø> (ø)
spp_registry	86.83% <ø> (ø)
spp_security	66.66% <ø> (ø)
spp_starter_disability_registry	0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
spp_disability_registry/__manifest__.py	0.00% <ø> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.