Skip to content

[cudf] Thread memory resources through equality/hash row preprocessing - #23617

Draft
nirandaperera wants to merge 4 commits into
NVIDIA:pull-request/23581from
nirandaperera:preprocessed-table-mr
Draft

[cudf] Thread memory resources through equality/hash row preprocessing#23617
nirandaperera wants to merge 4 commits into
NVIDIA:pull-request/23581from
nirandaperera:preprocessed-table-mr

Conversation

@nirandaperera

Copy link
Copy Markdown
Contributor

Description

Depends on #23581

A part of #20780.

Equality and hash preprocessed_table paths still allocated temps from the current device resource, so harness-based tests could not prove explicit MR routing. This change requires cudf::memory_resources on those APIs and updates callers accordingly.

  • Equality/hash preprocessed_table::create, self_comparator, two_table_comparator, and row_hasher take required mr and use mr.get_temporary_mr() for preprocessing temps
  • Call sites across join/groupby/hash/search/reductions/etc. pass an explicit mr
  • Add BaseFixtureWithHarness and convert row-operator tests to use harness stream()/resources(), with TODOs where lexicographic still falls back to the current resource

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 11, 2026
@nirandaperera nirandaperera added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 11, 2026
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
@nirandaperera
nirandaperera force-pushed the preprocessed-table-mr branch from c61b6e1 to da6ce69 Compare August 12, 2026 17:07
@nirandaperera
nirandaperera changed the base branch from main to pull-request/23581 August 12, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant