[cudf] Route dictionary encode and gather temps through memory_resources - #23642
Draft
nirandaperera wants to merge 25 commits into
Draft
[cudf] Route dictionary encode and gather temps through memory_resources#23642nirandaperera wants to merge 25 commits into
memory_resources#23642nirandaperera wants to merge 25 commits into
Conversation
Adds defaulted stream and memory_resources parameters to cudftestutil column wrappers and helpers so tests can control allocation and stream routing. Includes MR tests for wrappers and timestamp generators. Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
…df into test-column-wrappers-mr
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
nirandaperera
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: niranda perera <niranda.perera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #23581 #23617
A part of #20780.
dictionary::encodeand the detail gather path still allocated scratch from the current device resource, so dictionary row-hasher tests needed harness escape hatches. They now takecudf::memory_resourcesand split output vs temporary allocations, which lets those tests run underBaseFixtureWithHarnesswithoutenable_current_device_resource_use().dictionary::encode(anddictionary_column_wrapper) tocudf::memory_resourcesmemory_resourcesthrough detail gather / string gather /gather_bitmasksizes_to_offsetsandmake_offsets_child_columnscratch through an explicit temp MRChecklist