Fix: Update samples README using the link to the v11.0 data - #4824
Fix: Update samples README using the link to the v11.0 data#4824EstebanVg15 wants to merge 2 commits into
Conversation
* Having the direct link in the README makes easier for automated testing jobs to download, and install the correspoding sample data to run specific tests. * v11.0 sample data is used as well for v11.2 samples. Signed-off-by: Esteban Vazquez <esteban.vazquez@canonical.com>
brnguyen2
left a comment
There was a problem hiding this comment.
Same change as #4816, reverted by the 11.2 release drop (1dade06) since samples/README.md is overwritten wholesale from the internal tree. Fine to merge, but it will regress again at 11.3 unless someone mirrors it internally — worth an NVIDIA-side owner picking that up.
Notes on lines outside the diff:
- samples/README.md:53: Now that step 1 names the exact file, the placeholder here is stale —
unzip tensorrt_sample_data_20260602.zip(or awget <url>line above it) would make the block copy-pasteable, which is the stated point of the change.
@brnguyen2 I have an MR open to fix this internally before the next release branch is cut. |
* This makes more clear the way of downloading the zip package. Signed-off-by: Esteban Vazquez <esteban.vazquez@canonical.com>
|
Hello @zeroepoch and @brnguyen2 , Thanks for your quick response and feedback! According to @brnguyen2 comments, I just pushed a commit defining a block code with the corresponding |
We merged the previous diff into upstream |
Description.
Having the direct link in the README makes easier for automated testing jobs to download, and install the corresponding sample data to run specific tests.
v11.0 sample data is used as well for v11.2 samples.