Skip to content

Fix: Update samples README using the link to the v11.0 data - #4825

Open
EstebanVg15 wants to merge 2 commits into
NVIDIA:release/11.2from
EstebanVg15:release-11.2
Open

Fix: Update samples README using the link to the v11.0 data#4825
EstebanVg15 wants to merge 2 commits into
NVIDIA:release/11.2from
EstebanVg15:release-11.2

Conversation

@EstebanVg15

Copy link
Copy Markdown
Contributor

Description.

  • Having the direct link in the README makes easier for automated testing jobs to download, and install the corresponding sample data to run specific tests.

  • v11.0 sample data is used as well for v11.2 samples.

 * Having the direct link in the README makes easier
   for automated testing jobs to download,
   and install the correspoding sample data to
   run specific tests.

 * v11.0 sample data is used as well for v11.2 samples.

Signed-off-by: Esteban Vazquez <esteban.vazquez@canonical.com>
@EstebanVg15
EstebanVg15 requested a review from a team as a code owner August 4, 2026 22:51

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: the asset URL resolves (302 to the release asset) and the commit is signed off. Same change as #4816, which the 11.2 release drop (1dade06) overwrote — worth landing it in the internal tree too, otherwise the next release branch will revert it again.

 * This makes more clear the way of downloading the zip package.

Signed-off-by: Esteban Vazquez <esteban.vazquez@canonical.com>
@EstebanVg15

Copy link
Copy Markdown
Contributor Author

Hello @zeroepoch and @brnguyen2 ,

Thanks for the feedback, according to @brnguyen2 comments in this PR (#4824), I just pushed a commit defining a block code with the corresponding wget command, so the zip file can be easily downloaded by the users, could you please let me know if that sounds better to you? if it does not, I can revert my last commit.

@zeroepoch

Copy link
Copy Markdown
Contributor

@EstebanVg15

Thanks for the feedback, according to @brnguyen2 comments in this PR (#4824), I just pushed a commit defining a block code with the corresponding wget command, so the zip file can be easily downloaded by the users, could you please let me know if that sounds better to you? if it does not, I can revert my last commit.

The new code block flows naturally and fits right into that section of the README. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants