-
-
Notifications
You must be signed in to change notification settings - Fork 271
London | May-2026-itp | Vitalii Kmit | Sprint 2 | Book library #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vitalii-code
wants to merge
17
commits into
CodeYourFuture:main
Choose a base branch
from
Vitalii-code:feature/book-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8eaa64a
Fix errors
Vitalii-code b7a0641
Display author and check correclty
Vitalii-code c27230b
Convert script into module
Vitalii-code d9215d8
apply suggestions from https://validator.w3.org
Vitalii-code b9b0ab3
Add html validation
Vitalii-code 7f4447e
Change page count to Integer
Vitalii-code a1f2494
Trim input text
Vitalii-code 31bfa27
Use textContent instead of innerHTML
Vitalii-code 6a4344b
Make render() more efficient
Vitalii-code 7cd2449
Make variables more consistent
Vitalii-code c81cdb8
use const instead of let for non-reassigned variables
Vitalii-code 03672e3
refactor: clean up script.js per code review feedback
Vitalii-code 026b2af
Declare variables at the top of the file
Vitalii-code 6525196
Check for decimal numbers
Vitalii-code a58e76e
Use ternary operator
Vitalii-code 12ccc8d
Use form to enable validation
Vitalii-code 2473edb
Remove dead code
Vitalii-code File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,21 @@ | ||
| let myLibrary = []; | ||
| const myLibrary = []; | ||
|
|
||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const checkInput = document.getElementById("check"); | ||
|
|
||
| document.querySelector("form").addEventListener("submit", (e) => { | ||
| e.preventDefault(); | ||
|
|
||
| const form = e.target; | ||
| if (!form.checkValidity()) { | ||
| form.reportValidity(); | ||
| return; | ||
| } | ||
|
|
||
| addBook(); | ||
| }); | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| populateStorage(); | ||
|
|
@@ -7,38 +24,43 @@ window.addEventListener("load", function (e) { | |
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); | ||
| const book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| 127, | ||
| true | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| function addBook() { | ||
| const cleanTitle = titleInput.value.trim(); | ||
| const cleanAuthor = authorInput.value.trim(); | ||
| const pageCount = Number(pagesInput.value); | ||
|
|
||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| cleanTitle == "" || | ||
| cleanAuthor == "" || | ||
| pagesInput.value.trim() == "" || | ||
| Number.isNaN(pageCount) || | ||
| !Number.isInteger(pageCount) || | ||
| pageCount <= 0 | ||
|
Comment on lines
+49
to
+52
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: Two of these checks are optional (redundant). |
||
| ) { | ||
| alert("Please fill all fields!"); | ||
| alert("Please fill all fields correctly!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| const book = new Book( | ||
| cleanTitle, | ||
| cleanAuthor, | ||
| pageCount, | ||
| checkInput.checked | ||
| ); | ||
| myLibrary.push(book); | ||
| render(); | ||
| } | ||
| } | ||
|
|
@@ -50,54 +72,49 @@ function Book(title, author, pages, check) { | |
| this.check = check; | ||
| } | ||
|
|
||
| function showMessage(text) { | ||
| const msg = document.createElement("div"); | ||
| msg.className = "alert alert-info"; | ||
| msg.textContent = text; | ||
| document.body.prepend(msg); | ||
| setTimeout(() => msg.remove(), 3000); | ||
| } | ||
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
| const tbody = document.querySelector("#display tbody"); | ||
| tbody.innerHTML = ""; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| const length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| const row = tbody.insertRow(); | ||
| const titleCell = row.insertCell(0); | ||
| const authorCell = row.insertCell(1); | ||
| const pagesCell = row.insertCell(2); | ||
| const wasReadCell = row.insertCell(3); | ||
| const deleteCell = row.insertCell(4); | ||
| titleCell.textContent = myLibrary[i].title; | ||
| authorCell.textContent = myLibrary[i].author; | ||
| pagesCell.textContent = myLibrary[i].pages; | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| const changeButton = document.createElement("button"); | ||
| changeButton.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeButton); | ||
| let readStatus = myLibrary[i].check ? "Yes" : "No"; | ||
| changeButton.textContent = readStatus; | ||
| changeButton.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| render(); | ||
| }); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| const deleteButton = document.createElement("button"); | ||
| deleteCell.appendChild(deleteButton); | ||
| deleteButton.className = "btn btn-warning"; | ||
| deleteButton.textContent = "Delete"; | ||
| deleteButton.addEventListener("click", function () { | ||
| const deletedTitle = myLibrary[i].title; | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| showMessage(`You've deleted title: ${deletedTitle}`); | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| .form-group { | ||
| width: 400px; | ||
| height: 300px; | ||
| align-self: left; | ||
| align-self: center; | ||
| padding-left: 20px; | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.