London | May-2026-itp | Vitalii Kmit | Sprint 2 | Book library - #554
Open
Vitalii-code wants to merge 17 commits into
Open
London | May-2026-itp | Vitalii Kmit | Sprint 2 | Book library#554Vitalii-code wants to merge 17 commits into
Vitalii-code wants to merge 17 commits into
Conversation
Vitalii-code
added
the
Needs Review
cjyuan
reviewed
Aug 14, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
Vitalii-code
added
Needs Review
Contributor
|
Could you go through the guide again and make all possible improvements? |
cjyuan
added
Reviewed
- Rename DOM reference variables to signal element type (titleInput, authorInput, pagesInput, checkInput) - Change myLibrary from let to const - Trim title/author before storing, not just validating - Reject non-numeric and non-positive page counts - Replace blocking window.alert() with non-blocking showMessage() banner for delete confirmation
Vitalii-code
added
Needs Review
cjyuan
reviewed
Aug 17, 2026
cjyuan
added
Reviewed
Author
|
Ok, should be good now |
Vitalii-code
added
Needs Review
cjyuan
reviewed
Aug 17, 2026
Comment on lines
+49
to
+52
| pagesInput.value.trim() == "" || | ||
| Number.isNaN(pageCount) || | ||
| !Number.isInteger(pageCount) || | ||
| pageCount <= 0 |
Contributor
There was a problem hiding this comment.
Note: Two of these checks are optional (redundant).
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Fixed the bugs