Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 44 additions & 47 deletions debugging/book-library/index.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Rizqah's Book Library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -28,48 +25,48 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<form id="book-form">
<div class="form-group">
<label for="title">Title:</label>
<input
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
step="1"
required
/>
<div class="form-check">
<input class="form-check-input" type="checkbox" id="check" />
<label class="form-check-label" for="check"> Read </label>
</div>
<input
type="submit"
value="Submit"
class="btn btn-primary"
id="submit"
/>
</div>
</form>
</div>

<p id="message"></p>
<table class="table" id="display">
<thead class="thead-dark">
<tr>
Expand Down
136 changes: 76 additions & 60 deletions debugging/book-library/script.js
Original file line number Diff line number Diff line change
@@ -1,46 +1,55 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");
const bookForm = document.getElementById("book-form");

function setup() {
populateStorage();
render();
});

}

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);

myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
function addBook(event) {
event.preventDefault();
const titleValue = titleInput.value.trim();
const authorValue = authorInput.value.trim();
const pagesValue = pagesInput.value;
if (titleValue === "" || authorValue === "" || pagesValue === "") {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}

const pages = Number(pagesValue);

if (pages <= 0 || !Number.isInteger(pages)) {
alert("Please enter a valid page number.");
return false;
}

const book = new Book(titleValue, authorValue, pages, checkInput.checked);

myLibrary.push(book);
render();
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +60,60 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
const tableBody = document.querySelector("#display tbody");

//delete old table rows
tableBody.innerHTML = "";

//insert updated row and cells
let length = myLibrary.length;
const length = myLibrary.length;

for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const row = tableBody.insertRow();

const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
const changeButton = document.createElement("button");
changeButton.className = "btn btn-success";
wasReadCell.appendChild(changeButton);

const readStatus = myLibrary[i].check ? "Yes" : "No";
changeButton.textContent = readStatus;

changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteButton = document.createElement("button");
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";
deleteCell.appendChild(deleteButton);

deleteButton.addEventListener("click", function () {
const bookTitle = myLibrary[i].title;

myLibrary.splice(i, 1);
render();

const message = document.getElementById("message");
message.textContent = `You've deleted title: ${bookTitle}`;

setTimeout(function () {
message.textContent = "";
}, 3000);
});
}
}
bookForm.addEventListener("submit", addBook);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

This makes it easier to locate and manage all the code that runs once when the app starts.

window.addEventListener("load", setup);
19 changes: 13 additions & 6 deletions debugging/book-library/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,19 @@
.btn {
display: block;
}

.form-check-label {
padding-left: 20px;
margin: 5px 0px 5px 0px;
}

button.btn-info {
margin: 20px;
}
#message {
margin: 15px 0;
padding: 0;
color: #155724;
font-weight: 500;
}

#message:not(:empty) {
padding: 12px 16px;
background-color: #d4edda;
border-left: 4px solid #28a745;
border-radius: 4px;
}
Loading