London | 26-ITP-May | Rizqah Popoola | Sprint 2 |Book Library by risikatpopoola · Pull Request #549 · CodeYourFuture/Module-Data-Flows

risikatpopoola · 2026-08-13T17:39:10Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

In this PR, i have fixed all the bugs in script.js and refactored the script to be more efficient. I have also validated the html code to ensure it's free of errors.

cjyuan

Solid start.

I think there are some improvements you could still make.

cjyuan · 2026-08-13T21:28:29Z

@@ -1,46 +1,58 @@
 let myLibrary = [];


Could we declare myLibrary in a way that prevents it from being accidentally reassigned?

I have now declared this using const

cjyuan · 2026-08-13T21:55:50Z

          type="submit"
          value="Submit"
          class="btn btn-primary"
          onclick="submit();"


Could you research the trade-off between

attaching event listener in HTML

attaching event listener usng .addEventListener() in JS?

It is easier to manage event listeners in js and it provides more control.

cjyuan · 2026-08-13T21:57:06Z

+    titleInput.value.trim(),
+    authorInput.value.trim(),


A better and safer approach to deal with user input is to first preprocess/sanitise them, and then store the cleaned values in variables. Thereafter, refer only to the variables for cleaned values consistently throughout the rest of the code.

…isible

cjyuan · 2026-08-17T00:47:02Z

+    const submitButton = document.getElementById("submit");
+
+    submitButton.addEventListener("click", submit);


Why attach the event listener to the submit button here?

I completely removed the event listener for the submit button and added it to the book form submission instead.

How many times do you expect the app to add the event listeners to the submit button?

It should only be once, i have now taken it out of setup

cjyuan · 2026-08-17T12:03:16Z

Please note that if you have made any changes, you need to push them to GitHub.

cjyuan

Changes look good.

cjyuan · 2026-08-19T20:26:09Z

  }
 }
-
+bookForm.addEventListener("submit", addBook);


Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

This makes it easier to locate and manage all the code that runs once when the app starts.

book library bugs fixed

14c327c

This comment has been minimized.

Sign in to view

risikatpopoola added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 13, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2026

This comment has been minimized.

Sign in to view

risikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2026

cjyuan reviewed Aug 13, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2026

risikatpopoola added 2 commits August 16, 2026 22:20

pages input field made to only accept whole number and checkbox now v…

2789a2d

…isible

button submit event listener added

99b4684

risikatpopoola added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 16, 2026

cjyuan reviewed Aug 17, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2026

risikatpopoola added 2 commits August 17, 2026 03:31

used a formatter to ensure consistent styling

bcf2210

added bookform event listener is the appropriate place.

7c477d7

risikatpopoola added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 17, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2026

bookform event listeners out of setup

28120ac

risikatpopoola removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Aug 19, 2026

risikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 19, 2026

cjyuan reviewed Aug 19, 2026

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 19, 2026

		const submitButton = document.getElementById("submit");

		submitButton.addEventListener("click", submit);

Uh oh!

Uh oh!

Conversation

risikatpopoola commented Aug 13, 2026

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Aug 17, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants