feat(media): add validated upload adapter - #111
Open
xyh202131 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| async function readResponseBody(response: Response): Promise<unknown> { | ||
| try { | ||
| return await response.json() | ||
| } catch { |
Contributor
There was a problem hiding this comment.
response.json() can reject with AbortError if the request is cancelled after the headers arrive but before the body is consumed. This catch block wraps every rejection as UploadRequestError, which contradicts the documented abort behavior and makes late cancellations look like upload failures. Re-throw aborts here (or special-case DOMException.name === 'AbortError') so callers can still handle cancellation separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /media/uploadMediaReferenceVITE_API_BASE_URLis missing instead of posting to the visitor's localhostScope
Frontend only. No page, WorkflowRun, Controller, backend, object-storage configuration, database, log or build artifact is included.
Verification
format:checkremains blocked by 41 pre-existing files onmain; this PR does not mix those unrelated rewrites into the upload featureCloses #109