fix(zetaclient): keep signing when the keygen record is reset (backport v38)

[kingpinXD]

Backport of #4618 to release/zetaclient/v38. Do not merge before #4618.

Summary

• Whitelist p2p peers from TSS.TssParticipantList rather than the keygen record, which zetacore erases on any observer set change.
• Skip the keygen ceremony when a TSS already exists, instead of waiting on a record scheduled for a block that never arrives.
• Delete the keygen watcher that restarted every signer at once.
• Retry every zetacore query on the startup path with a constant backoff, so a contended RPC during a mass restart does not kill startup.

Scope

Production code only, matching the drain backports (#4614 / #4615). Five files: zetaclient/tss/setup.go, service.go, zetaclient/maintenance/tss_listener.go and the two test files. The e2e harness, CI wiring and changelog stay on main — they conflict on this branch and carry no runtime behaviour.

Compatibility with the drain

No shared files, and no drain code reads the keygen record. Setup runs before startDrainIfArmed in cmd/zetaclientd/start.go, so a signer that died in Setup never reached the drain at all — this fix is a prerequisite for the drain rather than a conflict.

Verified on this branch: build clean, zetaclient/tss and zetaclient/maintenance green, and the drain suites still green under -tags drain.

This branch is what testnet signers run, and it already carries the testnet drain anchors, so a build cut from here carries both the drain and this fix.

For operators

While a finalized TSS exists, a keygen scheduled via MsgUpdateKeygen will not run. Rotating requires removing the current TSS first. Tracked in #4623.

Greptile Summary

This backport keeps existing signers operational after zetacore resets the keygen record.

• Resolves the p2p whitelist from finalized TSS participants instead of erased keygen grantees.
• Skips key generation when a finalized TSS already exists.
• Removes keygen-record-triggered signer restarts.
• Adds constant-backoff retries to zetacore queries on the startup path.
• Adds focused coverage for whitelist selection and listener behavior.

Confidence Score: 5/5

The PR appears safe to merge, with no blocking failure remaining from the previously reviewed fallback behavior.

No blocking failure remains.

Important Files Changed

Filename	Overview
zetaclient/tss/setup.go	Selects peers from finalized TSS state, bypasses the obsolete keygen wait for existing keys, and retries startup queries.
zetaclient/tss/service.go	Retries the metrics-related keygen query consistently with the rest of startup.
zetaclient/maintenance/tss_listener.go	Removes keygen-record watching while retaining restart triggers for actual TSS changes.
zetaclient/tss/setup_test.go	Covers finalized, blanked, imported, query-failure, and invalid-peer whitelist states.
zetaclient/maintenance/tss_listener_test.go	Verifies keygen resets are ignored while TSS address and history changes still trigger shutdown.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Start zetaclient Setup] --> B[Retry keygen query]
    B --> C[Retry current TSS query]
    C --> D{Finalized TSS exists?}
    D -- Yes --> E[Whitelist TSS participants]
    E --> F[Skip keygen ceremony]
    D -- No --> G[Whitelist keygen grantees]
    G --> H[Run keygen ceremony]
    F --> I[Retry TSS history query]
    H --> I
    I --> J[Start signing service]
    K[TSS listener] --> L{TSS address or history changes?}
    L -- Yes --> M[Restart signer]
    L -- Keygen record only --> N[Keep signer running]

Loading

_{Reviews (2): Last reviewed commit: "Merge branch 'release/zetaclient/v38' in..." | Re-trigger Greptile}

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[codecov]

Codecov Report

❌ Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
zetaclient/tss/setup.go	80.85%	9 Missing ⚠️
zetaclient/tss/service.go	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[ws4charlie]

LGTM — diffed this against #4618 and all five files are byte-identical, and the pre-patch baselines match across main/v37/v38 so the cherry-pick is clean. Built it and ran the tss + maintenance unit tests locally, both green.