Skip to content

[test-qa-hourly] Cover video worker claim database failures - #131

Merged
i-xtsu-sixyou-ken-mei merged 1 commit into
mainfrom
test-qa/ongoing-coverage-20260728
Jul 29, 2026
Merged

[test-qa-hourly] Cover video worker claim database failures#131
i-xtsu-sixyou-ken-mei merged 1 commit into
mainfrom
test-qa/ongoing-coverage-20260728

Conversation

@i-xtsu-sixyou-ken-mei

@i-xtsu-sixyou-ken-mei i-xtsu-sixyou-ken-mei commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • extend the video worker polling regression coverage for repository claim failures
  • verify visual claim errors reject the poll instead of being treated as an empty queue
  • verify localization claim errors reject after an empty visual queue
  • verify neither path invokes processors or job failure persistence before a job is claimed

Why

A database/RPC failure during claim is operationally different from an idle, version-fenced queue. Treating it as empty would hide an outage; routing it through fail() would mutate a job that was never claimed.

Scope

  • test-only change in the existing video worker idle test
  • no production code, dependencies, workflow, documentation, or CI gate changes

Validation

Focused first, then broader validation:

pnpm --filter @zapengine/podcast-pipeline test -- src/services/video-worker-idle.test.ts
pnpm --filter @zapengine/podcast-pipeline format:check
pnpm --filter @zapengine/podcast-pipeline test:ci
pnpm verify changed

Latest run

  • commit: 809dbe36
  • GitHub Actions CI #738: success
  • PR is open, non-draft, mergeable, and limited to one test-only file (+64/-0)
  • no review submissions or unresolved review threads
  • rechecked on 2026-07-29 05:00 JST; no new CI, review, scope, or mergeability blocker was found

Auto-merge

All PR-level QA safety conditions are satisfied. Repository-level GitHub auto-merge remains unavailable, so no immediate merge or protection bypass was used.

Next QA target

After merge, add a focused regression for a successfully claimed job whose processor fails, verifying only that claimed job is persisted as failed and the other queue is untouched.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
zap-engine-frontend Ready Ready Preview, Comment Jul 28, 2026 9:08am
zap-engine-landing-page Ready Ready Preview, Comment Jul 28, 2026 9:08am

Copy link
Copy Markdown
Contributor Author

Continuous QA run — 2026-07-29 12:58 JST

Inspected:

Results:

  • PR [test-qa-hourly] Cover video worker claim database failures #131 remains open, non-draft, mergeable, and test-only (+64/-0).
  • Branch is safely synchronized: ahead 1, behind 0.
  • CI #738 remains successful.
  • No skipped/todo/focused tests were found in the podcast pipeline test area.
  • No new commit was added: the previously suggested “claimed processor failure only marks its own queue” behavior is already meaningfully covered in video-worker.test.ts for both visual and localization jobs, so adding it here would duplicate coverage and create noise.

Validation/source-of-truth checks:

GitHub compare main...test-qa/ongoing-coverage-20260728 -> ahead 1 / behind 0
GitHub Actions CI #738 -> completed / success
GitHub code search for skipped/todo/focused tests -> no matches

Auto-merge remains unavailable at repository level; no immediate merge or protection bypass was attempted.

Next recommended QA target: inspect notification failure/retry behavior around reapFailedNotifications() and markFailureNotified() for an uncovered state transition before extending this PR.

@i-xtsu-sixyou-ken-mei
i-xtsu-sixyou-ken-mei merged commit c1f1e98 into main Jul 29, 2026
9 checks passed
@i-xtsu-sixyou-ken-mei
i-xtsu-sixyou-ken-mei deleted the test-qa/ongoing-coverage-20260728 branch July 29, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant