Say what the permit observer's Bad floor does and does not catch at restart - #688
Open
xmap wants to merge 1 commit into
Open
Say what the permit observer's Bad floor does and does not catch at restart#688xmap wants to merge 1 commit into
xmap wants to merge 1 commit into
Conversation
…estart The floor's docstring argued at length for Bad-not-Good, because 2-BM's SecureM sits at MAJOR whenever the hutch is unsecured, but never said what else the floor is holding. An earlier draft of this commit claimed it guards the IOC-restart window outright. Measurement says otherwise, so the note now records the limit instead of the reassurance. A record that has never had a value assigned reports STAT=UDF with SEVR=INVALID, arrives as Bad, and closes the gate. A record given a value without processing does not: a field(VAL, ...) default at load, or an autosave restore at boot, clears UDF and leaves SEVR=NO_ALARM, so it reads Good while still carrying no substrate timestamp. Measured on a scratch IOC, base 7.0.8 with autosave R5-11. Which group SecureM falls into is unconfirmed, so the floor must not be treated as a restart guard. produced_at is the only signal that separates the two, and this path carries it as evidence without gating on it. Mechanism confirmed on tomography/tomoscan#182. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstring only, no behaviour change.
permit_status_from_readingspends twenty lines justifying itsBad-not-Goodquality floor, because 2-BM's SecureM sits at MAJOR whenever the hutch is unsecured. It never said what else that floor is or is not holding.My first draft of this claimed the floor guards the IOC-restart window outright. Measurement says otherwise, so the note records the limit instead:
STAT=UDFwithSEVR=INVALID, arrives asBad, and closes the gate.field(VAL, ...)default at load, or an autosave restore at boot, clearsUDFand leavesSEVR=NO_ALARM, so it readsGoodwhile still carrying no substrate timestamp.Measured on a scratch IOC (EPICS base 7.0.8, autosave R5-11) rather than inferred. Which group SecureM falls into is unconfirmed, so the floor must not be treated as a restart guard, and the docstring now says so.
produced_atis the only signal separating the two cases, and this path carries it as evidence without gating on it.Mechanism established in tomography/tomoscan#182.
🤖 Generated with Claude Code