geotiff: fix isort import ordering in _writers/eager.py#3330
Open
brendancol wants to merge 1 commit into
Open
Conversation
The geotiff subpackage has no flake8/isort gate in CI. isort (line_length=100 in setup.cfg) flagged the from .._validation import block in _writers/eager.py wrapping at the wrong column. Reflow only, no behavioural change. Also records the 2026-06-14 style re-sweep result in the sweep-style state CSV (geotiff row: flake8 baseline 0, Cat 4 isort only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3329.
What
The geotiff subpackage has no flake8/isort gate in CI, so import-ordering drift lands unnoticed. The style sweep ran the project's configured tooling (
flake8withmax-line-length=100,isortwithline_length=100from setup.cfg) across all 33 production files underxrspatial/geotiff/.Findings
_writers/eager.py: thefrom .._validation import (...)block wrapped at roughly 80 columns instead of isort's 100-column packing. Reflowed to match. No behavioural change.Everything else was clean:
== Falsein a comment,: dict/: listannotations, atype=keyword arg tosocket.getaddrinfo) are false positives, not bare excepts, mutable defaults, comparisons, or shadowed builtins.Verification
isort --check-only --diffclean after the fix.flake8clean.Import reformat only; no behavioural change is intended for any of the four backends. Found by the style sweep (/sweep-style, geotiff module).