fix: update deps and fix version bounds for 1.21.5+ / 26.1.2 support - #334
Open
joealjohn wants to merge 1 commit into
Open
fix: update deps and fix version bounds for 1.21.5+ / 26.1.2 support#334joealjohn wants to merge 1 commit into
joealjohn wants to merge 1 commit into
Conversation
Bump PacketEvents 2.12.2 -> 2.13.0 for full Minecraft 26.1.2 protocol support. Bump XSeries 13.7.0 -> 13.7.1 for latest material/entity mappings. Fix TridentDupe: remove erroneous V_1_21_4 upper version ceiling. The trident inventory-click dupe was never patched server-side, so the module should protect all 1.13+ servers, not just up to 1.21.4. Fix BookTitleDupe: correct inverted version logic (!isOlderThan -> isOlderThan). The original condition was backwards, causing the module to activate on 1.21.2+ (where the exploit is irrelevant) instead of 1.20.6-1.21.1 (where the exploit actually exists). The module was effectively broken. Also removed dead modernLimits code since the module never runs on 1.21.2+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump PacketEvents 2.12.2 -> 2.13.0 for full Minecraft 26.1.2 protocol support. Bump XSeries 13.7.0 -> 13.7.1 for latest material/entity mappings.
Fix TridentDupe: remove erroneous V_1_21_4 upper version ceiling. The trident inventory-click dupe was never patched server-side, so the module should protect all 1.13+ servers, not just up to 1.21.4.
Fix BookTitleDupe: correct inverted version logic (!isOlderThan -> isOlderThan). The original condition was backwards, causing the module to activate on 1.21.2+ (where the exploit is irrelevant) instead of 1.20.6-1.21.1 (where the exploit actually exists). The module was effectively broken. Also removed dead modernLimits code since the module never runs on 1.21.2+.