-
Notifications
You must be signed in to change notification settings - Fork 31
Add typing: asn, exceptions, hashes, pwdbased, utils. #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roberthdevries
wants to merge
10
commits into
wolfSSL:master
Choose a base branch
from
roberthdevries:add-more-typing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a538119
Add typing: asn, exceptions, hashes, hkdf, pwdbased, utils.
roberthdevries b7915af
Add typing information to ciphers.py
roberthdevries 0af6672
Address review comments and annotate overrides.
roberthdevries bcf35ca
Address more review comments.
roberthdevries 4bec7f3
Add py.typed file to indicate that this library has typing annotations.
roberthdevries 37e70ee
Addressed more review comments.
roberthdevries 7f3fcec
Address more review comments.
roberthdevries eda850a
Address more review comments.
roberthdevries 425813b
Rebased on master and fixed any (extra) issues found with ruff and ty.
roberthdevries e053b55
Enable and fix test_chacha_enc_dec.
roberthdevries File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 [Low] setup.py dependencies out of sync with pyproject (typing-extensions)
This PR makes
typing_extensionsa hard runtime import (from typing_extensions import overrideat module load in bothwolfcrypt/ciphers.pyandwolfcrypt/hashes.py) and correctly addstyping-extensions>=4.4.0to[project].dependenciesin pyproject.toml. However, setup.py still declaressetup_requires=["cffi>=1.17"]/install_requires=["cffi>=1.17"]with no mention of typing-extensions. Because the build backend issetuptools.build_meta:__legacy__and[project].dependenciesis present, the pyproject metadata is authoritative for PEP 517 wheel builds, so pip installs will still pull typing-extensions - i.e. this is not a functional break. It is a consistency issue: the two dependency lists now disagree, and anyone using the deprecatedpython setup.py installpath or reading setup.py as the source of truth would miss the new required dependency.Fix: Add
typing-extensions>=4.4.0to setup.py's install_requires to keep it in sync with pyproject.toml, or drop the redundant install_requires entirely and rely solely on the [project] table.