Skip to content

fix: variable shadowing crash in cancel, duplicate FilePicker modal #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix2015 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: variable shadowing crash in cancel, duplicate FilePicker modal #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,32 +457,6 @@ function AppContent() {
)}
</ToastContainer>

{/* File picker modal for selecting project directory */}
{showProjectPicker && (
<div className="fixed inset-0 z-50 flex items-center justify-center bg-background/80 backdrop-blur-sm">
<div className="w-full max-w-2xl h-[600px] bg-background border rounded-lg shadow-lg">
<FilePicker
basePath={homeDirectory}
onSelect={async (entry) => {
if (entry.is_directory) {
// Create or open a project for this directory
try {
const project = await api.createProject(entry.path);
setShowProjectPicker(false);
await loadProjects();
// Load sessions for the selected project
await handleProjectClick(project);
} catch (err) {
console.error('Failed to create project:', err);
setError('Failed to create project for the selected directory.');
}
}
}}
onClose={() => setShowProjectPicker(false)}
/>
</div>
</div>
)}
</div>
);
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/ClaudeCodeSession.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,8 +984,8 @@ export const ClaudeCodeSession: React.FC<ClaudeCodeSessionProps> = ({
if (!claudeSessionId || !isLoading) return;

try {
const sessionStartTime = messages.length > 0 ? messages[0].timestamp || Date.now() : Date.now();
const duration = Date.now() - sessionStartTime;
const sessionStartTimestamp = messages.length > 0 ? messages[0].timestamp || Date.now() : Date.now();
const duration = Date.now() - sessionStartTimestamp;

await api.cancelClaudeExecution(claudeSessionId);

Expand Down