[Feat] Scripts on events (#1070)#1196
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Delete events carry scalar primitives so the listener can reference them after the model row is gone. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ExecuteScript::executeForHook() runs a script in hook context, injecting event variables and skipping user-auth validation - RunScriptEventHooks handles all 6 event types; failures are caught per-hook so they never surface to the originating action - AppServiceProvider registers the listener for all 6 events - GetBootstrap exposes event metadata to the frontend via configs() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
16 tests covering CRUD, all 6 event types, disabled/cross-project skip, variable injection, and exception isolation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6dce205 to
f602e70
Compare
|
Thanks for submitting this PR for Vito, great work. I've taken the opportunity to fix the pre-commit activities for you, as well as resolved some bugs I noticed on review, notably some critical/high issues;
As well as a number of medium/low issues. Please do let us know if you plan to continue this PR (I noticed it was still draft), and if so I'll leave the rest for now, otherwise, I'm happy to pick up the remaining testing/updates (where required) for this PR - just let me know. |
Closes #1070
Attach an existing Script to a lifecycle event so it runs automatically whenever that event fires in a given project.
Events
site_domain,site_path,site_type,server_name,server_ipsite_domain,server_name,server_ipserver_name,server_ipserver_name,server_ipservice_name,service_type,service_version,server_name,server_ipservice_name,service_type,server_name,server_ipDesign notes
''(no prompt, no abort).Changes
ScriptEventHookmodel + migration + factoryCreateScriptEventHook/UpdateScriptEventHookactions (project write-access enforced)ScriptHookController+ScriptEventHookPolicy+ScriptEventHookResourceRunScriptEventHookslistener wired to all 6 events inAppServiceProviderExecuteScript::executeForHook()— transaction-wrapped, bypasses user authServerInstalledEvent,ServerDeletedEvent,ServiceInstalledEvent,ServiceUninstalledEventTesting
16 new feature tests covering CRUD, all 6 event types, disabled/cross-project skip, variable injection, and exception isolation.