Add right/left anchor placement for floating surfaces - #180
Open
OmarSiwy wants to merge 1 commit into
Open
Conversation
Extend WidgetAnchorPlacement with `right` and `left`, so a dropdown-menu or tooltip can float beside its trigger, not just above/below it. The X axis follows the same contract as the Y axis: prefer the named side, flip to the other when the surface doesn't fit and that side has more room, clamp the surface's width to the chosen side, and align its height against the anchor. anchoredWidgetFrame now branches per axis instead of assuming vertical; the markup validator, its error message, and the element/attribute docs accept the two new literals. Adds symmetric geometry tests for the horizontal path. Signed-off-by: omare <ok.elsawy@gmail.com>
|
@OmarSiwy is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #179
Sorry for the mass PR requests, I've been working on this for a week and debugging the library.