Sentry split type and value#50
Conversation
Greptile SummaryThis PR fixes the Sentry exception payload by correctly splitting the exception class name (
Confidence Score: 4/5The core fix is correct and improves Sentry event quality; the two observations are about discoverability and minor payload duplication that don't break anything. The change does the right thing structurally — Sentry events will now correctly distinguish exception class from message. The only rough edges are that the src/Logger/Adapter/Sentry.php — worth a second look at how callers are expected to supply Important Files Changed
|
| 'values' => [ | ||
| [ | ||
| 'type' => $log->getMessage(), | ||
| 'type' => $log->getTags()['verboseType'] ?? 'Exception', |
There was a problem hiding this comment.
Undocumented
verboseType tag convention
The verboseType key is only referenced here — it is never set anywhere else in this repository. Callers who do not explicitly add a verboseType tag will silently fall back to the generic 'Exception' type for every exception in Sentry, losing all class-name granularity. There is no doc-comment, constant, or Log method that signals this expectation to callers.
No description provided.