Skip to content

feat: Enforce pre-commit-check job passing in workflow#224

Merged
sumau merged 2 commits into
mainfrom
f-enforce-pre-commit
Jul 14, 2026
Merged

feat: Enforce pre-commit-check job passing in workflow#224
sumau merged 2 commits into
mainfrom
f-enforce-pre-commit

Conversation

@SamW94

@SamW94 SamW94 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: DBT pre-commit check

Description

Prevent PRs from being merged org-wide if the pre-commit check hasn't been run.

Contributors

@SamW94

Type of change

  • Refactoring (made code better without changing its behaviour)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How this has been tested

Pre-commit checks pass locally. Automated checks will run against this PR. This has been tested as a reusable workflow in a ruleset previously.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Reviewer Checklist

  • I have reviewed the PR and ensured no secret values are present

Signed-off-by: DBT pre-commit check
@SamW94 SamW94 requested a review from a team as a code owner July 13, 2026 16:29
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

Copy link
Copy Markdown

Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, however for more detailed help in setting up the pre-commit hooks, follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage

@sumau sumau merged commit 0cb2bdc into main Jul 14, 2026
18 checks passed
@sumau sumau deleted the f-enforce-pre-commit branch July 14, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants