Skip to content

Chore/release nsis prerelease#291

Merged
u8array merged 2 commits into
mainfrom
chore/release-nsis-prerelease
Jul 14, 2026
Merged

Chore/release nsis prerelease#291
u8array merged 2 commits into
mainfrom
chore/release-nsis-prerelease

Conversation

@u8array

@u8array u8array commented Jul 14, 2026

Copy link
Copy Markdown
Owner

No description provided.

@u8array
u8array merged commit f01d9c2 into main Jul 14, 2026
6 checks passed
@u8array
u8array deleted the chore/release-nsis-prerelease branch July 14, 2026 21:52

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the third-party Rust licenses documentation to include new dependencies and configures the bundle targets in tauri.conf.json. Feedback is provided regarding an invalid bundle target "app" in the Tauri configuration, which should be removed to avoid build validation errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src-tauri/tauri.conf.json
},
"bundle": {
"active": true,
"targets": ["nsis", "app", "dmg", "appimage", "deb", "rpm"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

"app" is not a valid bundle target in Tauri. The supported bundle targets are "all", "deb", "rpm", "appimage", "dmg", "nsis", "msi", and "updater". Including "app" will cause a configuration validation error during the build process.

Suggested change
"targets": ["nsis", "app", "dmg", "appimage", "deb", "rpm"],
"targets": ["nsis", "dmg", "appimage", "deb", "rpm"],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant