Skip to content

Feat/linux usb preview#285

Merged
u8array merged 2 commits into
mainfrom
feat/linux-usb-preview
Jul 13, 2026
Merged

Feat/linux usb preview#285
u8array merged 2 commits into
mainfrom
feat/linux-usb-preview

Conversation

@u8array

@u8array u8array commented Jul 13, 2026

Copy link
Copy Markdown
Owner

No description provided.

u8array added 2 commits July 13, 2026 04:14
Generalize the reply loop over AsyncRead so TCP, macOS nusb, and the Linux
usblp char device (driven through an AsyncFd adapter) share one framing.
Gate it by live enumeration like the print dialog and fall back to network
at fetch time when the selected USB device is gone.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extends USB printer querying and preview support to Linux (previously macOS-only) by implementing non-blocking I/O over the usblp character device using AsyncFd and generalizing the shared transport read-reply logic. It also updates the frontend to handle Linux-specific USB permissions and improves fallback behavior when USB devices are disconnected. However, the newly added lp_io module in src-tauri/src/usb.rs contains compilation errors in both poll_read and poll_write because inner.get_mut() is called on std::fs::File, which does not have this method; suggestions have been provided to resolve this by calling read and write directly on a mutable rebinding of inner.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src-tauri/src/usb.rs
Comment thread src-tauri/src/usb.rs
@u8array
u8array merged commit 059555b into main Jul 13, 2026
6 checks passed
@u8array
u8array deleted the feat/linux-usb-preview branch July 13, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant