Add Reset button to debugger toolbar after solver completion - #24
Open
seveibar wants to merge 1 commit into
Open
Add Reset button to debugger toolbar after solver completion#24seveibar wants to merge 1 commit into
seveibar wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
solvedorfailed) instead of leaving theSolvebutton disabled.Description
onSolverReset?: () => voidprop toGenericSolverToolbarand replaced the toolbar'sSolvebutton with aResetbutton whensolver.solved || solver.failed.handleSolverResetinGenericSolverDebuggerand passed it to the toolbar; the handler preferscreateSolver()when provided and otherwise attempts to reconstruct a new solver using the current solver constructor andgetConstructorParams().solverto state (useState) so it can be replaced withsetSolver(...), and callincRenderCount()to trigger a re-render after reset.getConstructorParams()result to an array before spreading into the constructor to avoid iterator errors.Testing
bun test testsand all tests passed (22 pass, 0 fail).bunx tsc --noEmitwhich succeeded with no errors.bun run formatwhich completed successfully.Codex Task