Skip to content

fix(cli): point to init when dev or update runs without a project#3929

Merged
ericallam merged 2 commits into
mainfrom
fix/cli-dev-without-project
Jun 12, 2026
Merged

fix(cli): point to init when dev or update runs without a project#3929
ericallam merged 2 commits into
mainfrom
fix/cli-dev-without-project

Conversation

@ericallam

Copy link
Copy Markdown
Member

Summary

Running trigger.dev dev before setting up a project crashed with a raw Cannot find matching package.json stack trace from a transitive dependency, instead of telling the user what to do next. It happens whenever dev (or update) runs in a directory with no package.json in it or any parent directory, for example right after creating an empty project folder, or when init was exited before it scaffolded anything.

The CLI now detects the missing project and prints actionable guidance pointing at init.

Fix

dev runs an embedded package-version check before it loads any project config. That check resolved package.json through a helper that throws when nothing is found up the tree, and nothing caught it. It is now wrapped, so a missing package.json produces a clear "run init" message and a clean exit.

The config loader had the same latent crash on the --skip-update-check path. Its resolvers for package.json, the lockfile, and the workspace root all ran before the friendly "couldn't find your trigger.config.ts" check, so any of them throwing masked it. That check now runs first and short-circuits before the resolvers touch the filesystem.

Verified live: in an empty directory, dev, dev --skip-update-check, and update all print a "run init" message and exit cleanly; in a configured project, dev still resolves config and boots normally.

@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a5c9119

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
trigger.dev Patch
@trigger.dev/build Patch
@trigger.dev/core Patch
@trigger.dev/plugins Patch
@trigger.dev/python Patch
@trigger.dev/react-hooks Patch
@trigger.dev/redis-worker Patch
@trigger.dev/rsc Patch
@trigger.dev/schema-to-json Patch
@trigger.dev/sdk Patch
@trigger.dev/database Patch
@trigger.dev/otlp-importer Patch
@trigger.dev/rbac Patch
@internal/cache Patch
@internal/clickhouse Patch
@internal/llm-model-catalog Patch
@internal/redis Patch
@internal/replication Patch
@internal/run-engine Patch
@internal/schedule-engine Patch
@internal/testcontainers Patch
@internal/tracing Patch
@internal/tsql Patch
@internal/zod-worker Patch
@internal/sdk-compat-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f66aba25-2a90-489a-8c34-fa4f9f3c9ba6

📥 Commits

Reviewing files that changed from the base of the PR and between fbb3065 and a5c9119.

📒 Files selected for processing (3)
  • .changeset/cli-dev-without-project.md
  • packages/cli-v3/src/commands/update.ts
  • packages/cli-v3/src/config.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/cli-dev-without-project.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/cli-v3/src/commands/update.ts
  • packages/cli-v3/src/config.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (32)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
  • GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
  • GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
  • GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
  • GitHub Check: Build and publish previews

Walkthrough

This PR prevents raw stack traces when running trigger.dev dev/update/etc. outside a project. resolveConfig now checks for a real trigger.config before invoking filesystem resolvers. updateTriggerPackages wraps getPackageJson in a try/catch to detect a missing package.json, prints guidance to run npx trigger.dev@latest init, and exits or returns false depending on embedded mode. A changeset documents the user-facing behavior change.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The pull request description is comprehensive and well-structured, covering the problem, root causes, solutions, and verification. However, it does not follow the provided template structure with the required checklist, testing, and changelog sections. Consider using the repository's PR description template with sections for the checklist, testing steps, changelog, and screenshots to maintain consistency with repository standards.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately and clearly summarizes the primary change: adding user-facing error handling and guidance when dev or update commands run without an initialized project.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cli-dev-without-project

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ericallam ericallam marked this pull request as ready for review June 12, 2026 15:55

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Running dev or update before a project existed crashed with a raw "Cannot find matching package.json" stack trace. The embedded version check and the config loader both resolved files up the tree before any friendly guidance could run; they now detect the missing project and point at npx trigger.dev@latest init.
@ericallam ericallam force-pushed the fix/cli-dev-without-project branch from fbb3065 to a5c9119 Compare June 12, 2026 16:18
@pkg-pr-new

pkg-pr-new Bot commented Jun 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@a5c9119

trigger.dev

npm i https://pkg.pr.new/trigger.dev@a5c9119

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@a5c9119

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@a5c9119

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@a5c9119

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@a5c9119

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@a5c9119

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@a5c9119

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@a5c9119

commit: a5c9119

@ericallam ericallam enabled auto-merge (squash) June 12, 2026 16:22
@ericallam ericallam merged commit 3d5cffc into main Jun 12, 2026
47 checks passed
@ericallam ericallam deleted the fix/cli-dev-without-project branch June 12, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants